kiwix/kiwix-android
1
0
Fork 0
mirror of https://github.com/kiwix/kiwix-android.git synced 2025-09-09 07:16:04 -04:00
Code Issues Packages Projects Releases Wiki Activity

#2110 Zoom controls disappeared in v3.3.1 - add summary for storage pref to have reliabe clickable element

Browse Source
This commit is contained in:
Sean Mac Gillicuddy 2020-06-11 10:53:45 +01:00
parent fcb17f320e
commit 0435d73f64
3 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
app/src/androidTest/java/org/kiwix/kiwixmobile/settings/KiwixSettingsActivityTest.java
View File

@ -60,12 +60,9 @@ public class KiwixSettingsActivityTest {
assertDisplayed(R.string.pref_language_title); assertDisplayed(R.string.pref_language_title);
} }
/*
* This will fail locally but needs these values to pass on CI emulators
* */
@Test @Test
public void testStorageDialog() { public void testStorageDialog() {
clickOn(R.string.external_storage); clickOn(R.string.pref_storage_summary);
assertDisplayed(R.string.internal_storage); assertDisplayed(R.string.internal_storage);
} }

1
core/src/main/res/values/strings.xml
View File

@ -275,6 +275,7 @@
<string name="diagnostic_report_message">Please send all the following details so we can diagnose the problem</string> <string name="diagnostic_report_message">Please send all the following details so we can diagnose the problem</string>
<string name="percentage">%d%%</string> <string name="percentage">%d%%</string>
<string name="pref_text_zoom_title">Text Zoom</string> <string name="pref_text_zoom_title">Text Zoom</string>
<string name="pref_storage_summary">Choose where files get saved to</string>
<string-array name="pref_night_modes_entries"> <string-array name="pref_night_modes_entries">
<item>@string/on</item> <item>@string/on</item>
<item>@string/off</item> <item>@string/off</item>

1
core/src/main/res/xml/preferences.xml
View File

@ -69,6 +69,7 @@
<PreferenceCategory <PreferenceCategory
android:key="pref_storage" android:key="pref_storage"
android:title="@string/pref_storage" android:title="@string/pref_storage"
app:summary="@string/pref_storage_summary"
app:iconSpaceReserved="false"> app:iconSpaceReserved="false">
<Preference <Preference