kiwix/kiwix-android
1
0
Fork 0
mirror of https://github.com/kiwix/kiwix-android.git synced 2025-09-13 09:26:52 -04:00
Code Issues Packages Projects Releases Wiki Activity

Remove Label From Dialog Box

Browse Source
This commit is contained in:
Priyank Shankar 2023-01-07 22:41:11 +05:30 committed by Kelson
parent 692176fd9d
commit fe459e6902
2 changed files with 31 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
core/src/main/java/org/kiwix/kiwixmobile/core/utils/dialog/AlertDialogShower.kt
View File

@ -34,6 +34,11 @@ import javax.inject.Inject
class AlertDialogShower @Inject constructor(private val activity: Activity) : class AlertDialogShower @Inject constructor(private val activity: Activity) :
DialogShower { DialogShower {
private val viewSpacingLeftForLink = 0
private val viewSpacingRightForLink = 0
private val viewSpacingTopForLink = 10
private val viewSpacingBottomForLink = 0
override fun show(dialog: KiwixDialog, vararg clickListeners: () -> Unit, url: URL?) = override fun show(dialog: KiwixDialog, vararg clickListeners: () -> Unit, url: URL?) =
create(dialog, *clickListeners, url = url).show() create(dialog, *clickListeners, url = url).show()
@ -77,14 +82,14 @@ class AlertDialogShower @Inject constructor(private val activity: Activity) :
Toast.LENGTH_SHORT Toast.LENGTH_SHORT
).show() ).show()
} }
textView.text = Html.fromHtml(" <b>Link - <b></br><a href=$url> <b>$url</b>") textView.text = Html.fromHtml("</br><a href=$url> <b>$url</b>")
setView( setView(
textView, textView,
0, viewSpacingLeftForLink,
20, viewSpacingTopForLink,
0, viewSpacingRightForLink,
0 viewSpacingBottomForLink
) )
} }
dialog.getView?.let { setView(it()) } dialog.getView?.let { setView(it()) }

24
core/src/test/java/org/kiwix/kiwixmobile/core/utils/ExternalLinkOpenerTest.kt
View File

@ -47,7 +47,13 @@ internal class ExternalLinkOpenerTest {
val externalLinkOpener = ExternalLinkOpener(activity, sharedPreferenceUtil, alertDialogShower) val externalLinkOpener = ExternalLinkOpener(activity, sharedPreferenceUtil, alertDialogShower)
externalLinkOpener.openExternalUrl(intent) externalLinkOpener.openExternalUrl(intent)
verify { verify {
alertDialogShower.show(KiwixDialog.ExternalLinkPopup, capture(lambdaSlot), any(), any()) alertDialogShower.show(
KiwixDialog.ExternalLinkPopup,
capture(lambdaSlot),
any(),
any(),
any()
)
} }
lambdaSlot.captured.invoke() lambdaSlot.captured.invoke()
verify { activity.startActivity(intent) } verify { activity.startActivity(intent) }
@ -61,7 +67,13 @@ internal class ExternalLinkOpenerTest {
val externalLinkOpener = ExternalLinkOpener(activity, sharedPreferenceUtil, alertDialogShower) val externalLinkOpener = ExternalLinkOpener(activity, sharedPreferenceUtil, alertDialogShower)
externalLinkOpener.openExternalUrl(intent) externalLinkOpener.openExternalUrl(intent)
verify { verify {
alertDialogShower.show(KiwixDialog.ExternalLinkPopup, any(), capture(lambdaSlot), any()) alertDialogShower.show(
KiwixDialog.ExternalLinkPopup,
any(),
capture(lambdaSlot),
any(),
any()
)
} }
lambdaSlot.captured.invoke() lambdaSlot.captured.invoke()
verify(exactly = 0) { activity.startActivity(intent) } verify(exactly = 0) { activity.startActivity(intent) }
@ -75,7 +87,13 @@ internal class ExternalLinkOpenerTest {
val externalLinkOpener = ExternalLinkOpener(activity, sharedPreferenceUtil, alertDialogShower) val externalLinkOpener = ExternalLinkOpener(activity, sharedPreferenceUtil, alertDialogShower)
externalLinkOpener.openExternalUrl(intent) externalLinkOpener.openExternalUrl(intent)
verify { verify {
alertDialogShower.show(KiwixDialog.ExternalLinkPopup, any(), any(), capture(lambdaSlot)) alertDialogShower.show(
KiwixDialog.ExternalLinkPopup,
any(),
any(),
capture(lambdaSlot),
any()
)
} }
lambdaSlot.captured.invoke() lambdaSlot.captured.invoke()
verify { verify {