7179 Commits

Author SHA1 Message Date
MohitMaliFtechiz
50eeddd314 Fixed: The chooser UI now defaults to displaying external storage.
* Previously, it displayed the last known location when selecting a folder for external storage, which could confuse the user. We have now resolved this by defaulting to opening the SD card when choosing the SD card folder.
2023-12-19 19:38:32 +05:30
Kelson
e693dd544a
Merge pull request #3614 from kiwix/Fixes-#3613
Fix potential infinite loop in bash script
2023-12-19 04:47:38 +01:00
MohitMaliFtechiz
bdbfe2f3d1 Fixed: $/${} is unnecessary on arithmetic variables error while incrementing the count of retry variable. Since In Bash arithmetic expansion, the $ is not needed when referencing variables see https://www.shellcheck.net/wiki/SC2004 for more details. 2023-12-18 16:56:53 +05:30
gouri-panda
23a984416f
Fixed #3613 2023-12-17 23:18:33 +05:30
Kelson
d0a951c5c5
Merge pull request #3603 from kiwix/update_changelog_for_3.9.0
Added a small change in the CHANGELOG for `3.9.0`.
3.9.0
2023-12-16 09:36:18 +01:00
MohitMaliFtechiz
7356bcd2be Added a small change in the CHANGELOG for 3.9.0. 2023-12-16 09:36:10 +01:00
Kelson
e33edbe0d7
Merge pull request #3602 from kiwix/Issue#3601
Fixed: Made a small improvement to the sidebar entries for "About the app" and "Support app."
2023-12-16 09:19:49 +01:00
MohitMaliFtechiz
dcc8a40751 Increased timeout for waiting the views in ZimHostFragmentTest since on Android 13 it takes time to find the views. 2023-12-15 19:09:22 +05:30
MohitMaliFtechiz
2423b6b683 * Fixed: Made a small improvement to the sidebar entries for "About the app" and "Support app."
* Introduced the 'Support kiwix' option, which is configurable in the navigation for custom apps. If the custom app is set to display the "Support" menu item in navigation, it will be shown; otherwise, it will be hidden from the app.
* Replaced the "kiwix" and "the" prefixes in "Support kiwix" and "About the app" with the app name in the navigation.
2023-12-15 16:44:25 +05:30
Kelson
bff68c0967
Merge pull request #3591 from kiwix/translatewiki
Localisation updates from https://translatewiki.net.
2023-12-14 15:16:36 +01:00
translatewiki.net
6bd22da364 Localisation updates from https://translatewiki.net. 2023-12-14 15:15:52 +01:00
Kelson
226213c015
Merge pull request #3580 from kiwix/Issue#3578
Fixed Zimit archives are not displaying correctly.
2023-12-14 15:06:51 +01:00
MohitMaliFtechiz
ced2182301 Fixed Zimit archives are not displaying correctly.
* The getEntryByPath method was being called twice when retrieving content. Consequently, the initial call returned the content entry URL with additional parameters. Subsequently, when making the second call with the provided URL, it resulted in an "entry not found" exception. This issue prevented the loading of the CSS and content of the Zim file.
* Additionally, the getActualUrl method was primarily implemented to retrieve the redirect entry of the URL provided by the webView. It is unnecessary to invoke this method when obtaining content.
2023-12-14 15:06:29 +01:00
Kelson
977baf588e
Merge pull request #3583 from kiwix/Issue#3576
Fixed Start-up message to inform about the restrictions on the Google Store app to open sideloaded ZIM files.
2023-12-14 15:03:57 +01:00
MohitMaliFtechiz
b572d02e6c Fixed HelpFragmentTest and PlayStoreRestrictionTest on api level 24 2023-12-14 15:03:01 +01:00
MohitMaliFtechiz
90dc8ec292 Enhanced the visibility of the ZIM file on the help screen for testability.
* Introduced test cases for the new functionality to ensure its expected behavior in both variants, such as Play Store and non-Play Store.
* Updated other test cases to accommodate the testing of this new functionality.
2023-12-14 15:03:01 +01:00
MohitMaliFtechiz
c20b40e389 Added a button to the startup message dialog to directly open the Kiwix website for downloading the APK. This will make it easier for the user who wants to download the full APK version of the Kiwix app. 2023-12-14 15:03:01 +01:00
MohitMaliFtechiz
c3a6a52255 Added play store restriction dialog 2023-12-14 15:03:01 +01:00
MohitMaliFtechiz
4d47198b90 Introducing the startup message dialog that shows the restrictions of the Play Store to the user. 2023-12-14 15:03:01 +01:00
MohitMaliFtechiz
a736a7bdea Fixed the URL shown in the help option and made it clickable to directly open our official website for downloading the APK. 2023-12-14 15:03:01 +01:00
MohitMaliFtechiz
7d276658d4 Fixed Start-up message to inform about the restrictions on the Google Store app to open sideloaded ZIM files.
* Showing play store restriction to the users in the help screen in play store variant.
2023-12-14 15:03:01 +01:00
Kelson
2745892a14
Merge pull request #3598 from kiwix/update_changelog_of_3.9.0
Updated `CHANGELOG` for `3.9.0`.
2023-12-14 15:02:33 +01:00
MohitMaliFtechiz
a1ec16a3c9 Updated CHANGELOG for 3.9.0. 2023-12-14 15:01:50 +01:00
Kelson
fb520a3c25
Merge pull request #3599 from kiwix/update_kiwix_version_to_3.9.0
Updated kiwix version to `3.9.0`.
2023-12-14 15:01:09 +01:00
MohitMaliFtechiz
4fdbf540e4 Updated kiwix version to 3.9.0. 2023-12-14 15:00:57 +01:00
Kelson
a32cc8616e
Merge pull request #3597 from kiwix/Issue#3590
Fixed: Add Configuration Option for Custom Apps: "About" Link in Sidebar
2023-12-14 15:00:18 +01:00
MohitMaliFtechiz
25eab4e5fb Introduced the 'About the app' option in the navigation for custom apps.
* If the custom app is configured to display the 'About the app' option in navigation, it will be visible. Clicking on it will redirect the user to the configured URL.
2023-12-14 12:44:05 +05:30
Kelson
eece22eb0f
Merge pull request #3582 from kiwix/Issue#3579
Fixed version `3.8.1` from Google Play cannot find zim on SD card that are copied to app-specific directory.
2023-12-14 07:56:20 +01:00
MohitMaliFtechiz
fc6740e4eb Fixed version 3.8.1 from Google Play cannot find zim on SD card that are copied to app-specific directory.
* Scan the app-specific directory as well because we have limitations in scanning all directories on Android 11 and above in the Play Store variant. If a user copies the ZIM file to the app-specific directory on the SD card, the scanning of the app-specific directory on the SD card has not been added, resulting in the copied files not being displayed on the library screen. Therefore, we need to explicitly include the app-specific directory for scanning.
2023-12-14 07:55:52 +01:00
Kelson
2632a85bfe
Merge pull request #3593 from kiwix/Issue#3577
Fixed unable to open zim files on sd card in version 3.8.1
2023-12-14 07:55:15 +01:00
MohitMaliFtechiz
1b6be45826 Fixed LocalLibraryTest that was failing. 2023-12-14 07:51:52 +01:00
MohitMaliFtechiz
736d95285d Fixed unable to open zim files on sd card in version 3.8.1
* If the ManageExternalStorage permission has not been granted, introduce the request, particularly when accessing features that necessitate this permission, such as downloading ZIM files, selecting a ZIM file from storage via the file picker, and refreshing the list of available ZIM files in storage.
2023-12-14 07:51:52 +01:00
Kelson
ee57a1ae64
Merge pull request #3594 from kiwix/Issue#3584
Fixes the issue where the "Help" submenu in the sidebar is misleading in custom apps.
2023-12-14 07:45:27 +01:00
MohitMaliFtechiz
3ca6a15058 Fixes the issue where the "Help" submenu in the sidebar is misleading in custom apps.
* We have hidden the help screen from our sidebar.
2023-12-14 07:45:15 +01:00
Kelson
fb0cdf478a
Merge pull request #3595 from kiwix/Issue#3586
Introduced the disable external links option for custom apps.
2023-12-14 07:43:51 +01:00
MohitMaliFtechiz
caf776a60d Introduced the disable external links option for custom apps.
* We have introduced the option to disable external links for custom apps. If a custom app is configured not to display the external links popup, it will both hide the external links preference from settings and refrain from showing the external link popup when opening external links. Additionally, we have included relevant comments within the methods and code to provide developers with a clear understanding of the reasons behind these changes.
2023-12-14 07:43:25 +01:00
Kelson
d65265b807
Merge pull request #3592 from kiwix/Issue#3581
Fixed the app crashes that occurred when deleting letters in a search.
2023-12-14 07:41:19 +01:00
MohitMaliFtechiz
a07bb680c3 Introduced a mutex to manage concurrency in the search functionality. This enables proper clearing of the first running job before executing a new one. By implementing this approach, we ensure that access to the libzim search results occurs one at a time, resolving the crashing issue caused by multiple attempts to access libzim resources.
* Replaced the `cancel` function for the Job with `cancelAndJoin`, ensuring that it thoroughly cancels the first job before initiating the new task.
2023-12-12 15:31:53 +05:30
MohitMaliFtechiz
6d5e50d0ef Fixed the SearchStateTest was failing due to improvements in the search loading functionality. 2023-12-11 19:12:18 +05:30
MohitMaliFtechiz
0bc1392f1b Fixed the app crashes that occurred when deleting letters in a search.
* Removed the unnecessary estimation matches call on `libkiwix`, as we do not need this since `libkiwix` can handle this automatically.
* Cancelled the previously running job if a new searchTerm is in progress; this will avoid unnecessary memory allocation and data load on libkiwix.
2023-12-11 18:04:04 +05:30
Kelson
78e186d65f
Merge pull request #3588 from Shreyassp002/develop
Improved Sidebar icon for Support Kiwix
2023-12-10 11:18:31 +01:00
Shreyas Patil
1a13516fcd Improved Sidebar icon for Support Kiwix 2023-12-10 02:13:48 +05:30
Kelson
64582cf47a
Merge pull request #3566 from kiwix/Issue#3547 2023-12-06 19:47:49 +01:00
MohitMaliFtechiz
e391b407b2 Fixed the left margin on the placeholder to make it look nice on the phone. 2023-12-06 17:05:43 +05:30
MohitMaliFtechiz
bbcf8bea8c Added a placeholder for search in custom apps.
* Introduced a search placeholder for custom apps; if any custom app is configured not to show the title in the toolbar, it will display the search placeholder with a border. To implement this change, a layout has been added inside the toolbar.
* To enhance understanding of this change, proper comments have been added to the methods.
2023-12-06 16:00:35 +05:30
MohitMaliFtechiz
88475d8601 The app icon will no longer automatically be replaced with three lines after closing the tabs screen in custom apps when the custom app is configured not to show the title. 2023-12-06 16:00:28 +05:30
MohitMaliFtechiz
2c1c678819 Fixed code formatting issue. 2023-12-06 16:00:22 +05:30
MohitMaliFtechiz
cd7b988fe1 Adjusted the size of the hamburger icon. * To address unexpected behavior, where setting the icon directly to the hamburger resulted in it taking the full width and height of the toolbar, we resized the app icon and applied it to the hamburger icon. 2023-12-06 16:00:15 +05:30
MohitMaliFtechiz
f46f2f324b Introduced the disable title option for custom apps. 2023-12-06 16:00:07 +05:30
MohitMaliFtechiz
952b539fa8 Adjusted the zone for triggering search suggestions.
* We had restricted the toolbar click to the toolbar title. So, if the user clicked on the title, it would initiate the search. Now, we have removed the restriction of clicking only on the title. If the user taps anywhere on the toolbar except the menu items and hamburger, it will initiate the search.
2023-12-06 15:59:59 +05:30