8665 Commits

Author SHA1 Message Date
MohitMaliFtechiz
20722fe15b Introduced support of OPDS catalog. * Created the OnlineLibraryManager class to manage the OPDS stream with libkiwix. * Refactored the ZimManageViewModel, and KiwixService code according to OPDS catalog. 2025-06-03 18:42:51 +05:30
Kelson
ccffb07ae4
Merge pull request #4331 from kiwix/Fixes#4244
Migrated the `Settings` screen to Jetpack Compose.
2025-06-02 15:14:33 +02:00
MohitMaliFtechiz
81b4a0be34 Fixed: Cancel button in language dialog was hidden due to oversized content. 2025-06-02 17:08:07 +05:30
MohitMaliFtechiz
5ab5529acf Refactored all UI test cases to align with the new settings Compose UI. 2025-06-02 16:50:08 +05:30
MohitMaliFtechiz
ba476058fe Fixed: The Text Zoom slider did not correctly display the previously set position after restarting the application.
* Removed the BaseDelegateAdapter and its subclasses, as RecyclerView is no longer used in the codebase.
* Fixed: CustomApps was crashing when opening the settings screen.
* Fixed: StorageList was not appearing on the settings screen.
* Fixed: Dark Mode and Language dialogs to match the theme design.
* Created KiwixBasicDialogFrame, a reusable Compose UI component to standardize the design of alert dialogs.
* Removed unused code from the project.
2025-05-30 17:55:02 +05:30
MohitMaliFtechiz
164e38b113 Refactored the remaining functionality to use Jetpack Compose UI.
* Improved the design of the `Settings` screen to match the previous XML layout.
* Updated the ViewModel to handle user interactions following the MVVM pattern.
* Introduced `SettingScreenState` to manage the state of the settings screen.
* Removed `KiwixPrefsFragment`, `CustomPrefsFragment`, and `CorePrefsFragment` as they are no longer needed.
* Cleaned up unused code from the project.
2025-05-29 19:04:40 +05:30
MohitMaliFtechiz
5aac7e4815 Migrated the Settings screen to Jetpack Compose.
* Created the `SettingsScreen` using Jetpack Compose UI components.
* Implemented `SettingsViewModel` to manage and update preferences reactively, supporting the Compose architecture.
* Refactored existing functionality to align with the Compose-based UI.
2025-05-29 19:04:40 +05:30
Kelson
5767f74fdb
Merge pull request #4325 from Abhi-Bohora/refacConnBroadRecvr
Refactored `RxJava` to `coroutines` in `ConnectivityBroadcastReceiver`.
2025-05-28 09:02:49 +02:00
MohitMaliFtechiz
6cae44821e Refactored RxJava to coroutines in ConnectivityBroadcastReceiver.
* Simplified the `combineToLanguageList` method and removed warnings.
* Refactored `ZimManageViewModelTest` to align with the changes.
* Removed unused `RxJava` code from the project.
* Removed all `RxJava` dependencies from the project.
* Updated the `README` file to reflect that `RxJava` is no longer used.
* Updated `credit.html` accordingly, similar to the `README`.
2025-05-27 17:48:28 +05:30
Kelson
ad62661e67
Merge pull request #4329 from kiwix/Fixes#4246
Migrated `SearchFragment` to jetpack compose.
2025-05-27 10:45:42 +02:00
MohitMaliFtechiz
de807f2a51 Fixed: SearchFragmentTestForCustomApp which sometimes failing on API level 33 and above. 2025-05-27 12:33:51 +05:30
MohitMaliFtechiz
3ee0977534 Removed debug logs. 2025-05-26 22:41:41 +05:30
MohitMaliFtechiz
0099f4dcf4 Fixed: CodeFactor issue. 2025-05-26 22:37:37 +05:30
MohitMaliFtechiz
31cc84664c Improved the KiwixSearchView to handle the keyboard onDone button press. Now, when the user presses the Done button on the keyboard, it triggers the search and opens the first matching item, if available.
* Fixed: The `FIND_IN_PAGE` button was appearing when the search was opened from `FromTabView`.
* Fixed: The `FIND_IN_PAGE` button was not displaying properly (only half was visible).
* Improved: The `NavigationIcon` to better support test cases.
* Fixed: `VoiceSearch` was not working when launched from the `SearchWidget`.
* Refactored: `SearchFragmentTest` and `SearchFragmentTestForCustomApp` to align with the Compose UI.
* Removed: Additional unused code from the project.
2025-05-26 22:31:25 +05:30
MohitMaliFtechiz
a3b1b95181 Migrated SearchFragment to jetpack compose.
* Improved the `KiwixAppBar` to show the textButton in actionMenu. Since we need to show the `FIND_IN_PAGE` textView button in actionMenu.
* Created the `SearchScreen` and migrated the all UI to compose from XML.
* Refactored the functionalities of `SearchFragment` according to compose UI.
* Removed the unused code from project.
2025-05-26 14:07:33 +05:30
Kelson
10494cccf9
Merge pull request #4328 from kiwix/Fixes#4302
Refactored `RxJava` to `coroutines` in `OnlineLibrary`.
2025-05-23 17:01:19 +02:00
MohitMaliFtechiz
e7b1c94f3b Improved the display of the "Downloading online library progress" message — previously, it was sometimes not shown, and only the progress bar at the top was visible.
* Updated the logic to hide the top progress bar when updating the library items while applying filters.
* Refactored all unit test cases to properly support coroutines.
2025-05-22 23:55:13 +05:30
MohitMaliFtechiz
989b22f563 Fixed: Network violation issue while downloading the online library.
* Fixed: Download progress of the online library was not displayed when navigating away from the fragment and returning while the download was still in progress.
* Fixed: Both the SwipeRefreshIndicator and the progress bar were shown simultaneously during the initial download of the online library.
* Improved: The logic for hiding the SwipeRefreshIndicator. It now automatically hides when the progress bar (with visible progress) is displayed.
* Improved: Handling of library re-downloads upon network state changes.
* Fixed: The progressBar was showing when we searching for books.
* Fixed: Compilation errors in unit test cases.
2025-05-21 18:44:25 +05:30
MohitMaliFtechiz
f5d55d2c8a Fixed compilation and lint issues.
* Fixed: Selected language filter was not being applied to the online library.
* Fixed: Unnecessary UI recomposition.
* Improved code readability and resolved related lint errors.
* Fixed: "Allow downloading content via mobile network?" dialog was not displaying correctly.
* Fixed: SwipeRefreshing was not working when the "Swipe Down for Library" message was shown.
* Improved: Previously, the online library would re-download every time the fragment was launched or brought to the foreground (e.g., when navigating back from another screen). This behavior has been changed to use coroutines. The library now downloads only once initially, and subsequent downloads only occur when the user manually refreshes the library. This helps reduce unnecessary data usage and network calls.
2025-05-20 17:05:09 +05:30
MohitMaliFtechiz
701fffb758 Refactored RxJava to coroutines in OnlineLibrary 2025-05-20 08:46:39 +05:30
Kelson
19929e6abb
Merge pull request #4313 from kiwix/translatewiki
Localisation updates from https://translatewiki.net.
2025-05-19 11:54:46 +02:00
translatewiki.net
5303d1b997 Localisation updates from https://translatewiki.net. 2025-05-17 12:33:42 +02:00
Kelson
307e7249de
Merge pull request #4322 from kiwix/Fixes#4308
Refactored the `RxJava` to coroutines in `PageViewModel`.
2025-05-16 16:30:38 +02:00
MohitMaliFtechiz
913068505d Refactored the all unit, and UI test cases.
* Removed the some unused code from project.
2025-05-16 16:08:51 +02:00
MohitMaliFtechiz
03f771bef1 Refactored the RxJava to coroutines in PageViewModel.
* Refactored the child viewModels (BookmarkViewModel, HistoryViewModel, and NotesViewModel) to use coroutines.
* Refactored all DAO classes to use coroutines instead of RxJava.
* Refactored all related code to align with coroutines.
2025-05-16 16:08:51 +02:00
Kelson
4a6933a06a
Merge pull request #4321 from kiwix/Fixes#4320
Fixed: CI sometimes crashes on `testBookmarks`.
2025-05-16 16:08:36 +02:00
MohitMaliFtechiz
21583e76c0 Fixed: The testBookmarks failing on Android 13 and above. 2025-05-16 15:43:45 +05:30
MohitMaliFtechiz
0c91e329d4 Fixed: CI sometimes crashes on testBookmarks.
* The issue was caused by using `CoroutineScope(Dispatchers.Main)` while our flow directly accessed the `uuid` of the ZIM file from the `ZimFileReader` object. When the fragment was switched to another screen, the `ZimFileReader` object got disposed. However, the `webViewProgressChanged` method would still trigger, initiating the flow to check if the current page was bookmarked. Since the `ZimFileReader` was already disposed, this resulted in a crash.
* We fixed this by using the viewLifecycleOwner.lifecycleScope so that the job is automatically cancelled when the fragment is destroyed. Additionally, we now retrieve the uuid once at the beginning and reuse it in the flow, avoiding repeated access to the disposed ZimFileReader.
* Improved the `testBookmarks` test case. Sometimes this test failed to find the "OPEN" button of the `Snackbar` because the `Snackbar` was automatically dismissed before `Espresso` could validate the view. This timing issue occasionally caused the test to fail. We've improved the test to properly verify whether the bookmark is saved, avoiding such situations.
* Improved the `DownloadTest`, which sometimes failed on CI.
2025-05-16 11:54:36 +05:30
Kelson
c69dc0190f
Merge pull request #4319 from kiwix/Fixes#4307
Refactored RxJava to coroutines in Fat32Checker, and `SharedPreferenceUtil`.
2025-05-16 08:22:36 +02:00
MohitMaliFtechiz
8e2b3c821c Refactored RxJava to coroutines in Fat32Checker, and SharedPreferenceUtil.
* Refactored all `RxJava` code in `SharedPreferenceUtil` to coroutines.
* Refactored `RxJava` code to coroutines in `Fat32Checker`.
* Refactored `RxJava` code to coroutines in `DarkModeConfig`.
* Refactored all related code of these classes accordingly.
* Updated unit test cases to work with coroutines.
2025-05-16 06:08:07 +02:00
Kelson
1c1559e3e1
Merge pull request #4312 from kiwix/Fixes#4306
Refactored the `RxJava` code to use Kotlin `Coroutines` in `WebServerHelper`.
2025-05-16 06:07:45 +02:00
MohitMaliFtechiz
42a1c46e19 Refactored the RxJava code to use Kotlin Coroutines in WebServerHelper.
* Refactored the IP address polling logic using coroutine Flow. Now the IP check runs on the IO thread and the result is pushed to the main thread, because our callbacks need to work on the main thread. Also, this whole operation will automatically cancel if the user switches the screen or if the given coroutine scope gets cancelled, since the scope is lifecycle-aware. This helps to avoid using extra resources unnecessarily.
* Added clear and concise method-level comments to improve code readability and help others easily understand the purpose and behavior of each method.
2025-05-16 06:07:34 +02:00
Kelson
2819c187ef
Merge pull request #4317 from kiwix/Fixes#4305
Refactored `RxJava` to `Coroutines` in `LanguageViewModel`.
2025-05-14 19:51:04 +02:00
MohitMaliFtechiz
163dfd3844 Refactored RxJava to Coroutines in LanguageViewModel.
* Removed duplicate method in `DownloadRoomDao` for fetching all downloads.
* Refactored `DownloadManagerMonitor` to use `Coroutines` instead of `RxJava`.
* Improved coroutine usage in `DownloadMonitorService`.
* Updated `LanguageViewModel` to use `Coroutine Flows` instead of `RxJava`.
* Refactored `NewLanguagesDao` to expose Coroutine Flows instead of `RxJava` observables.
* Updated `SaveLanguagesAndFinish` to use coroutines instead of `RxJava`.
* Created a `FlowExtension` utility class to add custom flow-related extensions. In this PR, added the `collectSideEffectWithActivity` extension function, which allows collecting `SideEffects` and handling them with the current Activity in a Compose UI. This also moved the `SideEffect` collection from the Fragment layer to the Compose screen, improving separation of concerns.
* Refactored the unit test cases according to this change.
2025-05-14 19:34:13 +05:30
Kelson
6351b60755
Merge pull request #4316 from kiwix/Fixes#4303
Refactored `RxJava` to use Kotlin `Coroutines` in `NewBookDao`.
2025-05-13 20:49:55 +02:00
MohitMaliFtechiz
ca2bdcb241 Fixed: GetContentShortcutTest sometimes failing on API level 30, and 33. 2025-05-13 21:34:00 +05:30
MohitMaliFtechiz
4f426e73ca Refactored RxJava to use Kotlin Coroutines in NewBookDao.
* Created an `asFlow` extension function to convert ObjectBox queries into coroutine Flow, enabling easier migration to coroutine-based flows in future tasks.
* Refactored all related code to use coroutine Flow.
* Updated all test cases to align with the new coroutine-based implementation.
2025-05-13 19:24:43 +05:30
Kelson
d71c0ac0f0
Merge pull request #4315 from kiwix/Fixes#4310
Refactored `RxJava` to `coroutines` in `ZimFileReader`.
2025-05-13 13:34:27 +02:00
MohitMaliFtechiz
d62800b7b1 Refactored RxJava to coroutines in ZimFileReader.
* Migrated ZIM content loading logic from RxJava to Kotlin coroutines.
* The previous implementation used `RxJava` to stream content on the IO thread, but it was not lifecycle-aware. This caused the task to continue running even when the WebView navigated away or stopped rendering.
* Updated the implementation to use coroutines, ensuring that the task is lifecycle-aware and automatically cancels when the page changes or the user navigates away.
* This improves resource efficiency and prevents unnecessary background work during page transitions.
2025-05-13 13:34:10 +02:00
Kelson
b2a65323b7
Merge pull request #4314 from kiwix/Fixes#4304
Refactored the code to use coroutines instead of rxJava for saving/retrieving the bookmarks from libkiwix.
2025-05-13 11:27:03 +02:00
MohitMaliFtechiz
3e92cda80f Refactored the code to use coroutines instead of rxJava for saving/retrieving the bookmarks from libkiwix.
* Refactored the all unit and UI test cases according to it.
2025-05-13 12:34:29 +05:30
Kelson
d6ef855795
Merge pull request #4311 from kiwix/Fixes#4309
Refactored the `RxJava` to coroutines in retrieving the webView history.
2025-05-12 20:09:36 +02:00
MohitMaliFtechiz
2f06598006 Refactored the RxJava to coroutines in saving/retrieving the webView history.
* Refactored the code to use the coroutine flow instead of `RxJava` flowable.
2025-05-12 12:41:20 +05:30
Kelson
2f7cdef02d
Merge pull request #4289 from kiwix/translatewiki
Localisation updates from https://translatewiki.net.
2025-05-10 08:22:10 +02:00
translatewiki.net
10aac7acae Localisation updates from https://translatewiki.net. 2025-05-10 08:21:56 +02:00
Kelson
716788de14
Merge pull request #4301 from kiwix/Fixes#2505
Refactored `RxJava` to `coroutines` in FileSearching.
2025-05-10 08:20:58 +02:00
MohitMaliFtechiz
4af14d8c98 Introduced the turbine library for efficiently testing the coroutine flows.
* Removed the `TestObserver` since it was sometimes stucks on the execution.
* Refactored the test cases according to turbine library.
2025-05-09 21:39:47 +05:30
MohitMaliFtechiz
2f9439391a Fixed: the unit test cases which were failing on CI. 2025-05-09 18:41:21 +05:30
MohitMaliFtechiz
bfb209acd5 Improved the scanning of ZIM files from storage.
* Improved the `TestObserver` to properly to receive the test values.
2025-05-09 16:12:30 +05:30
MohitMaliFtechiz
bbae4dbd64 Fixed: CustomFileValidatorTest which was failing on the CI.
* Improved the detecting of files from media directory.
* Fixed: `CustomDownloadViewModelTest` which was failing on CI.
2025-05-09 13:31:51 +05:30