8388 Commits

Author SHA1 Message Date
MohitMaliFtechiz
55bcccce8c Migrating the ErrorActivity in jetpack.
* Added the jetpack compose libraries in project.
2025-03-07 23:04:07 +01:00
Kelson
79f24b0b61
Merge pull request #4257 from kiwix/Fixes#4256
Migrated the deprecated `detekt` rules to new rules.
2025-03-07 22:58:07 +01:00
MohitMaliFtechiz
c5cc0cdd4c Migrated the deprecated detekt rules to new rules.
* Refactored the code according to the new rules of detekt.
2025-03-07 22:57:34 +01:00
Kelson
f96ab4d44d
Merge pull request #4229 from kiwix/translatewiki
Localisation updates from https://translatewiki.net.
2025-03-06 13:28:55 +01:00
translatewiki.net
b36e96e2ab
Localisation updates from https://translatewiki.net. 2025-03-06 13:05:53 +01:00
Kelson
e1b960dcdd
Merge pull request #4255 from kiwix/Fixes#4234
Fixed: Transparent images were not visible in "Dark mode".
2025-03-04 18:24:32 +01:00
MohitMaliFtechiz
20b19cdf46 Fixed: Transparent images were not visible in "Dark mode".
* Added a white background to transparent images so that when reading a ZIM file in "Dark mode," the content of transparent images displays properly.
* Added some debug logs in reader which will help us in diagnosing the problem if any occurred.
2025-03-04 17:38:41 +05:30
Kelson
86f38528f9
Merge pull request #4251 from amanna13/4236-improve-download-notification-strings
#4236 Improved download notification strings replacing default Fetch
2025-03-01 08:59:09 +01:00
Ambarish Manna
9fbf92a9d7 Merge branch 'main' of https://github.com/amanna13/kiwix-android into 4236-improve-download-notification-strings 2025-02-28 20:39:10 +05:30
Ambarish Manna
4a1da8b81e #4236 Improved download notification strings replacing default Fetch's string 2025-02-28 20:37:56 +05:30
Kelson
ed5f7160f1
Merge pull request #4240 from kiwix/Fixes#4237
Fixed: Duplicate download completed notifications showing.
2025-02-27 17:36:33 +01:00
MohitMaliFtechiz
e3c261dd9e Fixed: Duplicate download completed notifications showing.
* Two notifications were shown for a completed download when the app was in the background, the download was about to complete, and the app was then opened.
* This occurred because `DownloadMonitorService` pushed a download complete notification before detaching, while the app's lifecycle triggered Fetch to push another notification for the same completed download.
* The fix ensures that any previously completed notification is removed before showing a new one.
2025-02-27 17:36:10 +01:00
Kelson
9a82600496
Merge pull request #4239 from kiwix/Fixes#4235
Fixed: Duplicate resume/cancel buttons in download notification.
2025-02-27 17:35:54 +01:00
Ambarish Manna
ec3076ecb7 #4236 Improved download notification strings replacing default Fetch's string 2025-02-27 21:48:59 +05:30
MohitMaliFtechiz
765da6b651 Fixed: Duplicate resume/cancel buttons in download notification.
* When there is a single download running, and we pause the download from the notification then we push a custom notification and update the foreground service notification. So when we are pushing our custom notification it is performing on the IO thread, and when we are setting it on the foreground service, then instead of updating the same notification it creates a new notification and shows it, and in the meantime, our pushing the cancel notification finishes and push a second notification. Due to the same notification ID, it updates the same notification but its actions(resume/cancel) are added twice.
* We fixed it by synchronizing the process. Now, it first pushes the notification for paused download, and then if there is no other downloading going then it will set the current notification to foreground service.
2025-02-27 13:23:31 +01:00
Kelson
b025813607
Merge pull request #4238 from kiwix/Fixes#4086
Added carriage returns to improve readability in strings.
2025-02-27 13:23:06 +01:00
MohitMaliFtechiz
d5b7013df7 Added carriage returns to improve readability in strings. 2025-02-27 13:03:58 +05:30
Kelson
3514ed670a
Merge pull request #4233 from kiwix/Fixes#4232
Upgraded detekt and ktlint libraries to latest version.
2025-02-26 06:40:41 +01:00
MohitMaliFtechiz
37609ae0b1 Removed the unused code from project. 2025-02-24 17:39:49 +05:30
MohitMaliFtechiz
f9496ddfd4 Fixed: RedundantHigherOrderMapUsage detekt issue to reduce the memory usages 2025-02-24 17:35:20 +05:30
MohitMaliFtechiz
66874849e2 Fixed: UnsafeCallOnNullableType detekt issue 2025-02-24 17:30:23 +05:30
MohitMaliFtechiz
6e804384a9 Fixed: Remaining InjectDispatcher detekt issues. 2025-02-24 17:20:47 +05:30
MohitMaliFtechiz
649da61523 Fixed: DoubleMutabilityForCollection detekt issue 2025-02-24 16:46:18 +05:30
MohitMaliFtechiz
10446b27b2 Simplified some other conditions which is reported by the detekt. 2025-02-24 16:36:38 +05:30
MohitMaliFtechiz
d521acd3a6 Fixed: UseOrEmpty issue of detekt to simplify the conditions and use the already available extension functions 2025-02-24 16:23:35 +05:30
MohitMaliFtechiz
226289fbad Refactored the deprecated launchWhenCreated method with repeatOnLifecycle 2025-02-24 16:11:05 +05:30
MohitMaliFtechiz
5c2b27b9c1 Fixed: UseAnyOrNoneInsteadOfFind detekt issue to simplify the condition checks on loops 2025-02-24 15:44:40 +05:30
MohitMaliFtechiz
63a58e67b4 Fixed: UnusedParameter detekt issue 2025-02-24 15:35:10 +05:30
MohitMaliFtechiz
b49d168c08 Fixed: IgnoredReturnValue detekt issue 2025-02-24 15:30:37 +05:30
MohitMaliFtechiz
9a7fb2da3d Fixed: NestedBlockDepth detekt issue 2025-02-24 15:09:26 +05:30
MohitMaliFtechiz
cac2cd5a56 Fixed: ForEachOnRange detekt issue to improve the performance of our loops 2025-02-24 15:00:57 +05:30
MohitMaliFtechiz
3725e929a5 Upgraded the detekt dependency to version 1.23.8. * Fixed: NoNameShadowing detekt issue 2025-02-24 14:52:14 +05:30
MohitMaliFtechiz
422e93c6c5 Refactored the unnecessary code. 2025-02-24 14:31:56 +05:30
MohitMaliFtechiz
8527e2070d Improved the naming of constant variables to "SCREAMING_SNAKE_CASE," which is our default naming convention for constants.
* Fixed some other ktlint issues.
2025-02-24 12:42:31 +05:30
MohitMaliFtechiz
6721be1764 Upgraded detekt and ktlint libraries to latest version. 2025-02-21 19:05:43 +05:30
Kelson
102162fde3
Merge pull request #4227 from kiwix/Fixes#4226
Removed the uploading of unnecessary files in the release.
2025-02-16 09:42:14 +01:00
MohitMaliFtechiz
6ac9c5ef75 Removed the uploading of unnecessary files in the release.
* Now, only APK files will be uploaded in the release.
2025-02-14 11:34:31 +05:30
Kelson
f6aef1b7ea
Merge pull request #4219 from kiwix/translatewiki
Localisation updates from https://translatewiki.net.
3.14.0
2025-02-13 14:41:51 +01:00
translatewiki.net
262e327f20 Localisation updates from https://translatewiki.net. 2025-02-13 14:41:40 +01:00
Kelson
f9c164556e
Merge pull request #4225 from kiwix/Fixes#4224
Fixed: Opening SearchItem and FindInPage triggers again when switching back to the reader fragment.
2025-02-13 14:41:19 +01:00
MohitMaliFtechiz
5e74d626d0 Fixed: Opening SearchItem and FindInPage triggers again when switching back to the reader fragment.
* The issue occurred because when moving to another fragment, the `ReaderScreen` remained in the backstack and was not fully destroyed along with its data. Additionally, we were storing the `SearchItem` and `FIND_IN_PAGE` query in variables to perform these actions after restoring tabs. As a result, when reopening the `ReaderScreen`, the tabs were restored, and these variables retained their values, triggering the related actions again.
* To fix this, we have cleared these variables when the fragment is destroyed, as keeping them is unnecessary when the user navigates away from the reader screen.
2025-02-13 18:03:49 +05:30
Kelson
2017a4ea9e
Merge pull request #4218 from kiwix/Fixes#4216
Fixed: Kiwix cannot import ZIM files from the filesystem.
2025-02-13 10:27:07 +01:00
MohitMaliFtechiz
4735933fd5 Refactored the FileUtilsInstrumentationTest. 2025-02-13 10:26:37 +01:00
MohitMaliFtechiz
d974822481 Refactored the deprecated method used in our test cases. 2025-02-13 10:26:37 +01:00
MohitMaliFtechiz
6cdc8f23d4 Improved USB and External Hard Drive Path Retrieval for Android 10 and Above.
* The getExternalFilesDirs method only returns the USB path for devices running Android 9 (API 28) and below.
* On Android 10 (API 29) and above, this method returns null when accessing external storage like USB sticks.
* To work around this limitation, we previously appended the /mnt/media_rw/ path manually. While this worked in most cases, it was unreliable across different devices, as the mounted path could vary.
* To ensure accurate retrieval of external storage paths, we have switched to the StorageService API.
* This API, introduced in Android 11 (API 30), directly provides the actual mount paths for all external storage devices, including SD cards, USB sticks, and external hard drives.
* For Android 9 and below, getExternalFilesDirs continues to work as expected, so we use it where applicable.
* This improvement ensures that USB and SD card paths are retrieved correctly on modern Android devices.
* Added debugging logs to capture errors when opening a file in the reader.
* These logs will help us diagnose issues when users share a diagnostic report.
2025-02-13 10:26:37 +01:00
MohitMaliFtechiz
e6f378e165 Fixed: notifyFileOperationSuccess should handle invalid ZIM file unit test case. 2025-02-13 10:26:37 +01:00
MohitMaliFtechiz
496ddf1ea0 Updated the tarask string file 2025-02-13 10:26:37 +01:00
MohitMaliFtechiz
ae8974d682 Fixed: Kiwix cannot import ZIM files from the filesystem.
* Displaying a proper error message with the full ZIM path when there is an issue opening the ZIM file or if the selected file is not a valid ZIM file.
* Refactored `CopyMoveFileHandlerTest` to align with this change.
* Updated the documentation to help translators understand this update.
* To resolve the lint error, all string files have been updated. These files will be automatically updated in the latest TranslateWiki PR.
2025-02-13 10:26:37 +01:00
Kelson
50eeeecade
Merge pull request #4221 from kiwix/update_changelog_for_3.14.0
Updated the `CHANGELOG` file for milestone `3.14.0` to include the remaining changes made in this milestone.
2025-02-13 10:26:04 +01:00
MohitMaliFtechiz
15bb7d8de6 Updated the CHANGELOG file for milestone 3.14.0 to include the remaining changes made in this milestone. 2025-02-13 10:25:36 +01:00