7592 Commits

Author SHA1 Message Date
Kelson
8e08acea4e
Merge pull request #3870 from kiwix/Fixes#3869
Fixed: Long clicking on Download button in epub ZIM files shows the `Open in new tab` dialog which leads to a blank page.
3.11.0
2024-06-07 14:23:50 +02:00
MohitMaliFtechiz
630966d469 Fixed: Long clicking on Download button in epub ZIM files shows the Open in new tab dialog which leads to a blank page.
* We didn't account for the scenario where a user long-clicks on an image that contains an anchor tag with a URL. For now, we only check when a link is loading(when user simply clicks on the image button), and if the link is unsupported by Kiwix, we show the save/open dialog. Now, we are also checking for this scenario on long clicks.
2024-06-07 13:35:56 +02:00
Kelson
694e76bbb0
Merge pull request #3868 from kiwix/update_changelog_for_3.11.0
Updated the CHANGELOG file for `3.11.0`.
2024-06-07 13:35:39 +02:00
MohitMaliFtechiz
c4dbb6bb9c Added last bug fix in CHANGELOG file. 2024-06-07 16:52:01 +05:30
MohitMaliFtechiz
3980c45277 Updated the CHANGELOG file for 3.11.0. 2024-06-07 14:55:36 +05:30
Kelson
42f20ea8da
Merge pull request #3867 from kiwix/use_java_libkiwix_2.2.0
Use java-libkiwix `2.2.0`
2024-06-07 10:26:45 +02:00
MohitMaliFtechiz
1bff4b9efa Fixed the compilation errors due to the new java-libkiwix. 2024-06-07 13:07:06 +05:30
MohitMaliFtechiz
3a3f413c87 Use java-libkiwix 2.2.0 2024-06-07 12:48:06 +05:30
Kelson
f17e3f948d
Merge pull request #3738 from kiwix/Fix#3737
Fixed: Some EPUB files are not downloading.
2024-06-07 06:41:36 +02:00
MohitMaliFtechiz
13fb613ebf Improved the naming of unsupported mimeType handler class.
* Improved the dialog's message and title.
2024-06-07 06:41:25 +02:00
MohitMaliFtechiz
c928943851 Fixed DownloadOrOpenEpubAndPdfHandlerTest failing on API level 24. 2024-06-07 06:41:25 +02:00
MohitMaliFtechiz
38fb31b6e0 Added unit test cases for testing this functionality with all possible scenarios e.g. "Download Failed", "Download Successfull", "When no reader application is installed in device", "File opens in external reader application", "When user clicks on NO Thanks button". 2024-06-07 06:41:25 +02:00
MohitMaliFtechiz
8794774816 Introduced a Open/Download dialog for Epub/Pdf files.
* This was requested in #3453 and this PR is related to the Epub opening issue so we are introducing this here.
2024-06-07 06:41:25 +02:00
MohitMaliFtechiz
2258cfabcb Fixed: Some EPUB files are not downloading.
* The issue was epub fileName containing the colon ":" in it that is not supported by most of fileSystem, that's why it is not creating the file in fileSystem and we are not able to download the epub file.
* So to fix this we have improved our `getDecodedFileName` method which returns the fileName of the epub file, here we are removing the colon from fileName if any contains. For this change we have added the test cases as well for our `getDecodedFileName` function to properly test it.
* We also refined our downloadFileFromUrl method. Previously, the generateSequence function was used to create new files with underscores and incremented numbers, anticipating multiple attempts to save the same file. However, since we now save files only once in our storage, this feature is no longer utilized. This enhancement is detailed in issue #2879.
* Added epub query in our manifest to properly open epub files in external application.
2024-06-07 06:41:25 +02:00
Kelson
1b255d56dd
Merge pull request #3724 from kiwix/Fix#822
Added the 'Export bookmarks' feature.
2024-06-07 06:40:40 +02:00
MohitMaliFtechiz
9c6aeecae6 Added the test cases for "ImportBookmark" feature to properly test the importing of bookmarks. 2024-06-07 06:40:29 +02:00
MohitMaliFtechiz
b2aeab5fdb Fixed StorageObserverTest. 2024-06-07 06:40:29 +02:00
MohitMaliFtechiz
a771f00cc2 Improved the code of importing the bookmarks. 2024-06-07 06:40:29 +02:00
MohitMaliFtechiz
e83a040f02 Added test cases for testing the "Import Bookmark" feature. 2024-06-07 06:40:29 +02:00
MohitMaliFtechiz
42a4481707 Added the import bookmarks feature in setting screen.
* Refactored the test cases for this new change.
* Now user can easily import the exported bookmarks by just selecting the exported `bookmark.xml` file.
2024-06-07 06:40:29 +02:00
MohitMaliFtechiz
20925efb60 Improved the exporting of bookmarks.
* Improved the location of exporting the bookmarks.
* Improved the messages that will clearly shows where and in which file bookmarks are exported.
2024-06-07 06:40:29 +02:00
MohitMaliFtechiz
be1369f805 Added the 'Export bookmarks' feature.
* The application now exports 'bookmark.xml' file to the 'Android/media/org.kiwix...' folder. Users can copy this file to the 'Android/data/org.kiwix.../files/Bookmarks/' folder to view the exported bookmarks.
* Introduced an export bookmark feature in the settings screen, allowing users to easily export all bookmarks with a simple click. A dialog prompt appears before exporting, indicating the location where the exported bookmarks will be saved and providing instructions on how to import them.
* Added a test case for this change in our settings test.
2024-06-07 06:40:29 +02:00
Kelson
019c675b5f
Merge pull request #3862 from kiwix/Fixe#3861
Fixed: Saving bookmarks in the zim-split splitted ZIM files are crashing the application, when there is a 0 size extra zim chunk.
2024-06-07 06:37:41 +02:00
MohitMaliFtechiz
7849021247 Fixed: Saving bookmarks in the zim-split splitted ZIM files are crashing the application, when there is a 0 size extra zim chunk.
* Catching the exception thrown by the libkiwix with splitted ZIM files when there is an 0 size extra zim chunk.
2024-06-07 06:37:06 +02:00
Kelson
f702249c5e
Merge pull request #3865 from kiwix/update_kiwix_version_to_3.11.0
Upgraded the kiwix version to `3.11.0`.
2024-06-07 06:36:45 +02:00
MohitMaliFtechiz
f58559ed17 Upgraded the kiwix version to 3.11.0. 2024-06-07 06:36:29 +02:00
Kelson
3bd5380221
Merge pull request #3863 from kiwix/Fixes#3113
Migrated Notes to room database.
2024-06-07 06:35:49 +02:00
MohitMaliFtechiz
cf58340ee8 Removed the BasePageDao and RoomPageDao.
* We have refactored our code to use PageDao for managing data related to Bookmarks, Notes, and History. With the ability to return Flowable from the Room database, the BasePageDao interface has become unnecessary. Consequently, we have removed BasePageDao and streamlined our code to use PageDao, providing a unified approach for these functionalities. This change reduces code complexity and enhances readability, making the codebase easier to understand and maintain.
2024-06-07 06:35:21 +02:00
MohitMaliFtechiz
84e0b742c2 Added migration test cases for notes. 2024-06-07 06:35:21 +02:00
MohitMaliFtechiz
8f42e09c45 Added test cases for testing the NotesRoomDao via KiwixRoomDatabase. 2024-06-07 06:35:21 +02:00
MohitMaliFtechiz
2586c9c58f Added migration code of notes. 2024-06-07 06:35:21 +02:00
MohitMaliFtechiz
d044d20e83 Added NoteRoomDaoTest for testing the saving/deleting/retrieving scenario for notes.
* Refactored the code for a better naming convention.
2024-06-07 06:35:21 +02:00
MohitMaliFtechiz
348440ebc0 Migrated Notes to room database.
* Created NotesRoomDao, and NotesRoomEntity for saving the data in room database.
* Refactored the code for saving the notes in room database.
2024-06-07 06:35:21 +02:00
Kelson
9b1bb3da3c
Merge pull request #3855 from kiwix/translatewiki
Localisation updates from https://translatewiki.net.
2024-06-06 13:26:04 +02:00
translatewiki.net
a647c15c31 Localisation updates from https://translatewiki.net. 2024-06-03 14:09:01 +02:00
Kelson
5cf0881ea2
Merge pull request #3859 from kiwix/Fixes#3187
Migrated history to room database
2024-06-02 14:45:48 +02:00
MohitMaliFtechiz
a27dcc0b7e Improved the Migration test, since on slow devices/environments it will take more time for migration. 2024-05-31 19:01:31 +05:30
MohitMaliFtechiz
23759900de Improved the code for updating existing history. 2024-05-31 18:52:11 +05:30
MohitMaliFtechiz
d06045a1e7 Improved the migration code from 1 to 2. 2024-05-31 18:27:24 +05:30
MohitMaliFtechiz
e197ad4ab0 Fixed the application crashing when deleting the history.
* We have moved the deleting functionality to background thread because we should not perform any database operation on UI thread.
* Refactored all the test cases according to this change.
2024-05-31 18:05:56 +05:30
MohitMaliFtechiz
4898bacbc5 Fixed history was not showing on the HistoryScreen. 2024-05-31 17:03:47 +05:30
MohitMaliFtechiz
614b82c444 Added migration test cases for History. 2024-05-31 16:12:45 +05:30
MohitMaliFtechiz
68e1386344 Added test cases for HistoryRoomDao. 2024-05-31 15:14:21 +05:30
MohitMaliFtechiz
9538768165 Added migration code of history.
* Added the test cases in KiwixRoomDatabaseTest for testing the HistoryRoomDao.
2024-05-31 13:02:53 +05:30
MohitMaliFtechiz
60c905860f Fixed the compilation errors in HistoryRoomDao.
* Added he migration code in KiwixRoomDatabase.
2024-05-30 18:43:19 +05:30
MohitMaliFtechiz
c2446d27c4 Refactored the code for saving the history in room database. 2024-05-30 12:21:56 +05:30
MohitMaliFtechiz
e32e3e6371 Created HistoryRoomDao, and HistoryRoomEntity for saving the data in room database. 2024-05-30 11:12:31 +05:30
Kelson
09c482102f
Merge pull request #3858 from kiwix/Fixes#3111
Room introduction & migration of recent search
2024-05-30 06:08:12 +02:00
MohitMaliFtechiz
26cb6a69b7 Fixed the ObjectBoxToRoomMigratorTest.
* Improved the migration code of recent searches, now all the migration will be performed on the background thread so that it can not impact the UI thread.
2024-05-29 16:55:56 +05:30
MohitMaliFtechiz
0613d36ab9 Added KiwixRoomDatabaseTest, ObjectBoxToRoomMigratorTest, RecentSearchRoomDaoTest for testing all the scenarios of migration and saving the recent searches in room database.
* Improved the SaveSearchToRecentsTest.
* Removed unused code from project.
2024-05-29 14:36:59 +05:30