7778 Commits

Author SHA1 Message Date
MohitMali
ac78a67cf4 Improved the code, removed unnecessary parentheses 2023-09-18 19:13:20 +02:00
MohitMali
376776c099 Imrpvoed pagination search, avoid loading unnecessary data when user at the end of list and there is no data available to show 2023-09-18 19:13:20 +02:00
MohitMali
dd1ae68b4f Fixed duplicate searched items are showing 2023-09-18 19:13:20 +02:00
MohitMali
3edfd88cfb Updated test cases to accommodate the new search functionality.
* Due to linking errors with libkiwix/libzim functions, direct usage in testing was not possible. To address this, helper classes were created, similar to those in `java-libkiwix`, for testing the search functionality.
2023-09-18 19:13:20 +02:00
MohitMali
adea940f72 Introduced an endless suggestion list in search.
* With the integration of libkiwix12, we now receive full results based on the search term. Previously, we were loading the entire list, but we have now implemented pagination to enhance the search functionality.
* The libkiwix provides us with a Search object, which enables us to obtain the suggestion list using start and end indices. Consequently, we have modified our `ZimSearchResultGenerator` code to return the `Search` object instead of a list.
* To accommodate the changes, we have updated the return type of `SearchResultGenerator` to a nullable Search. This change is necessary because we initialize the `SearchState` when the search is initialized in `SearchViewModel`, and initially, we do not have the Search object available. The nullable return type allows us to pass the Search object when it becomes available.
2023-09-18 19:13:20 +02:00
MohitMali
69982e9db8 Fixed ZimMangeViewModelTest 2023-09-18 19:13:20 +02:00
MohitMali
3e40c095a4 Refactored ci to support minimum api level 24
* Since our minimum API level is now 24, we have updated our CI configuration to run on API level 24, which aligns with the minimum API level required for our project.
2023-09-18 19:13:20 +02:00
MohitMali
632bb4a528 Refactored code to remove lint errors
* Now our minimum SDK version is 24 and we are using some conditions placed on behalf of this api level which are unused now, so we have removed those conditions.
* Removed `CompatV21` file as now it is unused.
* Renamed `CompatV23` to `CompatV24` and refactored the code to support our new minimum api level.
* Refactored `NetworkUtilsTest` to support api level 24.
2023-09-18 19:13:20 +02:00
MohitMali
f7517a2272 Minimum SDK version changed to 24: The NDK version in kiwix-build has been upgraded (as mentioned in https://github.com/kiwix/kiwix-build/issues/544). However, to make this upgrade compatible, the minimum SDK version had to be updated to 24 since the NDK version is not compatible with Android API levels below 24. The README.md file has been updated to reflect the new minimum Android support version, which is now Android 7, due to the change in the minimum SDK version. Since the project's minimum SDK version is now 24, some conditions related to Android 23 and 24 have become unused. These unused conditions have been removed, and along with that, the drawable-night-23 and drawable-23 launch_screen.xml files, which were no longer in use, have also been removed. 2023-09-18 19:13:20 +02:00
MohitMali
d188a8262a Improved search functionality
* Fixed search unit test cases.
* Improved the search functionality to perform the unit test case for search.
2023-09-18 19:13:20 +02:00
MohitMali
46d4aeb505 Refactored SearchFragmentTest
* As we can not search in that zim file which is not contains the FT Xapian index and testzim.zim file is not contain it so we have improved our test case.
* Now we are downloading the `off the grid` zim file and performing the search functionality inside it.
2023-09-18 19:13:20 +02:00
MohitMali
e363889eaf Fixed search functionality crash if any FT Xapian index not found in any zim file 2023-09-18 19:13:20 +02:00
MohitMali
02a6d0f83f Fix the instrumentation test cases 2023-09-18 19:13:20 +02:00
MohitMali
6e0336ebf7 Using newly published 'libkiwix 1.0.0' from maven 2023-09-18 19:13:20 +02:00
MohitMali
bbd23d1693 Fixed loading content which contains a query params, mostly this fix is for newly created zim files 2023-09-18 19:13:20 +02:00
MohitMali
75fab0635e Refactored search functionality according to the new wrapper 2023-09-18 19:13:20 +02:00
MohitMaliFtechiz
e69499fa03 Removed the relinker dependency from the project, since now we are loading the .so files on the libkiwix side. Enabled the loadICUData method, since now it is fixed on the libkiwix side. Search and server is now starting successfully, but need some refactoring, for that see next commit. 2023-09-18 19:13:20 +02:00
MohitMali
384bacc877 Refactored code to safely get the metadata of zim files 2023-09-18 19:13:20 +02:00
MohitMali
161337a818 Start using libkiwix 11.0.0 from maven, loading wrappers .so files for fixing the jni crash which we have missed loading in libkiwix 2023-09-18 19:13:20 +02:00
MohitMali
a1ee8bec25 Fixed zim file size issue in library section 2023-09-18 19:13:20 +02:00
MohitMali
3e59e97af1 Refactoring the search functionality to support the latest wrapper 2023-09-18 19:13:20 +02:00
MohitMali
64f26202c5 Changes to support libkiwix 11.0.0 wrapper * Get correct zim file title from libkiwix. * Refactor code to get zim file tags from libkiwix * Decode the URL if it is encoded because libkiwix does not return the path for encoded paths. 2023-09-18 19:13:20 +02:00
MohitMali
d62d43957e Refactored the code to support the java-libkiwix 11.0.0 2023-09-18 19:13:20 +02:00
Kelson
4121f402b3
Merge pull request #3476 from kiwix/translatewiki
Localisation updates from https://translatewiki.net.
2023-09-18 19:10:23 +02:00
translatewiki.net
f29c206729 Localisation updates from https://translatewiki.net. 2023-09-18 13:08:06 +02:00
Kelson
4ae2c0d3cb
Merge pull request #3473 from kiwix/Issue#3472
Fixed Bookmark toggle is not ON for saved bookmarks
2023-09-04 17:47:07 +02:00
MohitMali
f029498e84 Added SYSTEM_ALERT_WINDOW permission for api level 21 as by default it is not launching the activity and giving error Could not launch intent Intent this error comes when we have not Display pop-up windows while running in the background permission 2023-08-31 19:18:44 +08:00
MohitMali
efc3dbffba Fixed Bookmark toggle is not ON for saved bookmarks 2023-08-31 19:18:44 +08:00
Kelson
51e2189cc9
Merge pull request #3471 from kiwix/Issue#3462
Fixed USB-OTG not working on android 11 and above devices
2023-08-31 19:08:15 +08:00
MohitMali
c1cbebd64f Enhanced ZIM file support for Android 10 and above devices, including USB-OTG integration.
* Previously we can only open zim files from `USB-OTG` in android 10 and below devices, because `context.getExternalFilesDirs("")` does not provide the USB path in android 10 and above devices for security reasons. There is no direct way to access the USB-OTG on these devices, but USB-OTG are mounted under the `/mnt/media_rw` directory, so now we are directly using this to open zim files from USB drive for android 10 and above devices.
2023-08-29 21:23:15 +07:00
Kelson
6ec78d0ed9
Merge pull request #3477 from kiwix/Issue#2889
Added tmpfs filesystem to `support 4GB filesystem` list and improved the writing test file name
2023-08-29 21:22:19 +07:00
MohitMali
8fee2d119a Enhanced FileSystem Check.
* Added `tmpfs` filesystem to `support 4GB filesystem list` since this type supports writing files over 4GB.
* Updated the name of the writing test result file to `kiwix_4gb_writing_test_result` to enhance readability.
2023-08-29 18:35:15 +05:30
Kelson
a8fdbc8114
Merge pull request #3422 from kiwix/translatewiki
Localisation updates from https://translatewiki.net.
2023-08-28 10:57:34 +07:00
translatewiki.net
64a2bba45d Localisation updates from https://translatewiki.net. 2023-08-24 13:10:10 +02:00
Kelson
3a788b939e
Merge pull request #3469 from kiwix/Issue#3468
Fixed Keyboard repeatedly disappearing and reappearing in search when any article is loading in the background
2023-08-19 18:28:27 +08:00
MohitMali
9e0541b54a Fixed Keyboard repeatedly disappearing and reappearing in search when any article is loading in the background.
* When any article is loading then we invalidate the `OptionMenu` from `KiwixWebChromeClient` (It does not check whether the fragment is visible or not) which also invalidates the toolbar and the search bar is inside the toolbar that's the reason the keyboard showing and hiding repeatedly.
* Now we are invalidating the `OptionMenu` inside the `CoreReaderFragment` when it is visible to the user since this fragment loads the content in the webview. Hence, it is better to update the UI when it is visible to the user so it would not affect any other UI part.
2023-08-18 18:49:27 +05:30
Kelson
b628d7c46c
Merge pull request #3414 from kiwix/Issue#3406
Updated README.md file to explain ZIM File Picker Restriction and Storage Scanning in play store variant
2023-08-17 11:33:22 +08:00
Emmanuel Engelhart
c1c1cac1ee
Few rewrittings 2023-08-17 11:30:10 +08:00
MohitMaliFtechiz
416edddb9a
Updated README.md file to explain ZIM File Picker Restriction and Storage Scanning in play store variant 2023-08-17 11:21:16 +08:00
Kelson
3b8ba6364b
Merge pull request #3464 from kiwix/Issue#3463
Fixes of Storage configured dialog showing again in OnlineLibraryFragment if we configured it from settings's screen
2023-08-17 11:13:37 +08:00
MohitMali
b624f1cbb5 Hide storage selection dialog from OnlineLibraryFragment if user already configured the storage in settings 2023-08-17 11:13:27 +08:00
Kelson
908a238856
Merge pull request #3459 from kiwix/PauseResumeDownload
Reintroduced Download pause/resume
2023-08-17 11:11:04 +08:00
MohitMali
64c3c041f6 Added test case for testing the pause/resume functionality 2023-08-01 12:15:17 +05:30
MohitMali
5b3aa73d53 Enabled pause/resume functionality in downloading notification 2023-07-31 13:50:31 +05:30
MohitMali
0a2cff92b5 Introduced pause/resume functionality.
* Added pause/resume button beside the stop button to perform pause/resume action on the downloading zim file.
* Handling pause/resume via fetch library.
2023-07-31 13:50:23 +05:30
MohitMali
524c469d78 Refactored the code to fix the issue, if we canceled downloading from the notification 2023-07-31 13:50:09 +05:30
MohitMali
ba4031258e Fixes of Zim file does not download / pending forever 2023-07-31 13:50:00 +05:30
Kelson
8469e18e23
Merge pull request #3439 from kiwix/Fixes#3370
Improved the permission asking scenario for custom apps
2023-07-26 07:44:55 +02:00
MohitMaliFtechiz
b1eb76e49b Improved the permission asking scenario for custom apps 2023-07-26 07:44:21 +02:00
Kelson
06c9dbc9ca
Merge pull request #3451 from kiwix/Issue#3441
Fixes of Zim file does not download / pending forever
2023-07-26 07:43:43 +02:00