MohitMali
842a7ee737
Fixed downloading pending forever if we canceled it from notification
2023-07-19 14:08:11 +05:30
Kelson
8a105ae296
Merge pull request #3440 from kiwix/Issue#3409
...
Introducing deprecated code check in CI
2023-07-19 08:09:43 +02:00
MohitMali
9d49bbbf31
Removed unnecessary classes from the custom rule and suppressed the Compat21 file because we are handling the deprecated code within it. Therefore, we don't want Detekt to check this file for deprecations.
2023-07-19 08:09:31 +02:00
MohitMali
ae5b3a5074
Added RuleSetProvider file to define our custom rules
2023-07-19 08:09:31 +02:00
MohitMali
8e6c74abe8
Introduced custom rule for detekt to exclude the deprecated imports
2023-07-19 08:09:31 +02:00
MohitMali
af23cf56b7
Detecting deprecated code via detekt and fixed detekt detection for the issues in project, and refactored deprecated rules of detekt
2023-07-19 08:09:31 +02:00
Kelson
73fe388514
Merge pull request #3449 from kiwix/Issue#3448
...
Fixes of View Notes from all books Switch is always enabled
2023-07-19 07:00:45 +02:00
MohitMali
38d6335860
Fixes of View Notes from all books Switch is always enabled
2023-07-19 07:00:35 +02:00
Kelson
c49d8d8ac3
Merge pull request #3447 from kiwix/Issue#3446
...
Fixes of `UnsafeCallOnNullableType` and `UnnecessaryAbstractClass` issues found by detekt
2023-07-19 06:57:36 +02:00
MohitMali
6e195fc42f
Fixed the UnsafeCallOnNullableType
detekt issue in the project.
2023-07-18 22:42:54 +02:00
MohitMali
7493b842b7
Fixed UnnecessaryAbstractClass issue of detekt
2023-07-18 22:42:54 +02:00
Kelson
1806495674
Merge pull request #3450 from kiwix/Issue#3395
...
Fixes of Refactor the Toolbar functionality
2023-07-18 22:41:38 +02:00
MohitMali
eeaceabf0a
Fixed test failure
2023-07-18 22:41:12 +02:00
MohitMali
f8594b0183
Moved the common toolbar functionality to the BaseFragment
2023-07-18 22:41:12 +02:00
Kelson
79e43d8735
Merge pull request #3444 from kiwix/Issue#3443
...
Fixes of Some deprecation warnings are showing in the logs but they are already fixed
2023-07-18 22:40:45 +02:00
MohitMali
7445da9bfc
Replaced deprecated onOptionsItemSelected
and onCreateOptionsMenu
methods with new MenuProvider API.
2023-07-05 18:06:39 +05:30
MohitMali
f2d130c547
Fixes of Some deprecation warnings are showing in the logs but they are already fixed
2023-07-03 18:44:33 +05:30
Kelson
0891512be7
Merge pull request #3433 from kiwix/Issue#3431
...
Fixes of KiwixWifiP2pBroadcastReceiver using some deprecated methods
2023-06-30 17:00:05 +02:00
MohitMaliFtechiz
ded00766ba
Fixes of KiwixWifiP2pBroadcastReceiver using some deprecated methods
2023-06-30 16:59:42 +02:00
Kelson
99f6fdf474
Merge pull request #3420 from kiwix/Issue#3419
...
Fixes of PreferenceManager.getDefaultSharedPreferences() is deprecated
2023-06-30 16:59:06 +02:00
MohitMaliFtechiz
7d3756af4e
Fixes of PreferenceManager.getDefaultSharedPreferences() is deprecated
2023-06-30 16:58:52 +02:00
Kelson
1fd71b51c9
Merge pull request #3436 from kiwix/Issue#3430
...
Fixed `Toast.getView()` and `Html.fromHtml()` is deprecated
2023-06-28 18:29:26 +02:00
MohitMaliFtechiz
36803af9e2
Fixed Toast.getView() and Html.fromHtml() is deprecated
...
* We already handled the deprecation of `fromHtml`, we have a string's extension function to handle the this so we are now using that function.
* Since `Toast.getView()` is no longer supported after Android 11 (it always returns null on Android 11 and above devices), we no longer need to show the toast on the ZIM file that is clicked by the user for UI enhancement. Therefore, we have removed this function and are now using the context class extension function to display the toast message.
2023-06-28 18:29:02 +02:00
Kelson
4723d869d2
Merge pull request #3437 from kiwix/Issue#3429
...
Fixed Auth.kt file using some deprecated method
2023-06-28 18:27:58 +02:00
MohitMaliFtechiz
aa86a88acb
Fixed Auth.kt file using some deprecated method
2023-06-28 18:27:50 +02:00
Kelson
8c20953b5d
Merge pull request #3432 from kiwix/Issue#3428
...
Fixes of Fragment's onActivityCreated is deprecated
2023-06-27 17:24:26 +02:00
MohitMaliFtechiz
8791a824b6
Fixes of Fragment's onActivityCreated is deprecated
2023-06-27 17:23:57 +02:00
Kelson
a32eac811d
Merge pull request #3411 from kiwix/Issue#3351
...
Fixed some `lintOptions` are deprecated
2023-06-27 17:23:08 +02:00
MohitMaliFtechiz
c18c9d7bba
Fixes for some Lint options have been deprecated in newer Gradle versions.
...
We have introduced a new method, configureCommonExtension, in the AllProjectConfigurer.kt file since Lint is only available in CommonExtension. This allows us to configure Lint in one place for every module. Previously, we couldn't directly use Lint in the android-library project, but with this approach, we can now configure Lint for the android-library project as well.
2023-06-27 17:22:59 +02:00
Kelson
3049494e3d
Merge pull request #3416 from kiwix/Issue#3415
...
Fixes of `isDrawingCacheEnabled` and `drawingCache` of View class is deprecated
2023-06-27 17:22:19 +02:00
MohitMaliFtechiz
a3de2a25c7
Fixed extra space on the webview top if the webview is not atteched to any view
2023-06-27 17:22:10 +02:00
MohitMaliFtechiz
17cbcf082d
Refactor tab preview to use WebView instead of creating a bitmap
...
This commit introduces changes to the tab preview functionality in order to improve performance and memory usage. The previous approach of creating and storing bitmaps for tab previews has been replaced with a more efficient method utilizing WebView.
Changes Made:
- Modified the onBindViewHolder method in TabsAdapter to utilize WebView for tab previews.
- Removed the ImageUtils.kt class as it is no longer needed for bitmap storage.
Impact:
- Improved performance and reduced memory usage by directly displaying the WebView for tab previews.
- Eliminated the need for bitmap creation and storage, resulting in a more efficient implementation.
2023-06-27 17:22:10 +02:00
MohitMaliFtechiz
03ee22eb8a
Removing the bitmap dependency to show the preview image
2023-06-27 17:22:10 +02:00
MohitMaliFtechiz
790de4e98e
Fixes of if we open tab in background then a blank preview is showing
2023-06-27 17:22:10 +02:00
MohitMaliFtechiz
802f130bb8
Fixes of isDrawingCacheEnabled and drawingCache of View class is deprecated
2023-06-27 17:22:10 +02:00
Kelson
949fefdad9
Merge pull request #3423 from kiwix/Issue#3421
...
Fixes of windowManager.defaultDisplay.getMetrics(this) is deprecated
2023-06-27 17:21:15 +02:00
MohitMaliFtechiz
663afd3eeb
Fixes of windowManager.defaultDisplay.getMetrics(this) is deprecated
2023-06-27 17:20:54 +02:00
Kelson
7c6f236f29
Merge pull request #3425 from kiwix/Issue#3424
...
Fixes of `KiwixWebView` using some deprecated methods
2023-06-27 17:19:56 +02:00
MohitMaliFtechiz
d2662c1aa4
Removed the deprecated FLAG_FULLSCREEN, FLAG_FORCE_NOT_FULLSCREEN.
...
We have removed the usage of deprecated flags FLAG_FULLSCREEN and FLAG_FORCE_NOT_FULLSCREEN. Instead, we are now using the updated API `WindowCompat.setDecorFitsSystemWindows` to handle fullscreen mode. This API automatically takes care of handling fullscreen behavior for both older and newer API levels.
2023-06-27 13:00:33 +05:30
MohitMaliFtechiz
35ff151e9b
Updated SaveHandler to use Bundle.get()
instead of deprecated
msg.data['url']`
2023-06-27 13:00:33 +05:30
MohitMaliFtechiz
97a17eac3a
Fixes of shouldOverrideUrlLoading and onReceivedError deprecated method of WebViewClient
2023-06-27 13:00:33 +05:30
MohitMaliFtechiz
bb0a49902e
Fixed supportInvalidateOptionsMenu() deprecated method used in KiwixWebChromeClient
2023-06-27 13:00:33 +05:30
MohitMaliFtechiz
2ff07a7606
Fixes of WebView.HitTestResult.IMAGE_ANCHOR_TYPE is deprecated
2023-06-27 13:00:33 +05:30
Kelson
b00c3ecc9e
Merge pull request #3417 from kiwix/Issue#3336
...
Fixes of ProgressDialog is deprecated
2023-06-23 07:03:38 +02:00
MohitMaliFtechiz
5256af49cd
The item_progressbar.xml file has been renamed to item_custom_spinner.xml for better readability of the file
2023-06-23 07:02:17 +02:00
MohitMaliFtechiz
543d336d4c
Changes after review
2023-06-23 07:02:17 +02:00
MohitMaliFtechiz
e081c856cd
Fixes of ProgressDialog is deprecated
2023-06-23 07:02:17 +02:00
Kelson
b2f97c2f6f
Merge pull request #3435 from CYBWEBALI/Issue#3434
...
Fixes of Snackbar buttons
2023-06-22 15:30:10 +02:00
CYBWEBALI
6f825f6277
Fixes of Snackbar buttons
2023-06-22 14:10:00 +05:30
Kelson
c29f40e128
Merge pull request #3427 from kiwix/Issue#3408
...
Fixes of Text to Speech init failed
2023-06-20 08:37:45 +02:00