7778 Commits

Author SHA1 Message Date
MohitMaliFtechiz
eb011e5c32 Corrected the fileName in SearchFragmentTest. 2024-05-20 12:05:44 +05:30
MohitMaliFtechiz
2137f47147 Added the accessibility check in remaining test cases.
* Added the `contentDescription` to AddNoteDialog's `close` image.
2024-05-20 12:05:32 +05:30
MohitMaliFtechiz
ff5f9fe162 Added the androidx.test.espresso:espresso-accessibility dependency to test the accessibility issues in our application.
* This testing library only work with `ViewAction` like if we perform any click on any screen then it starts checking the accessibility issues, so we have modify our test cases according to this.
* Suppress a few known accessibility issue e.g. on `LocalFileTransfer` screen we have a `skip` text which we are not using but it is giving the error for that.
* Fixed the `TouchTargetIssue` in ZimHostFragment.
* Added the `contentDescription` to search recyclerView.
2024-05-20 12:05:13 +05:30
MohitMaliFtechiz
037d02ab8c Added the contentDescription for views and suppressed this lint warning for some views since we are setting the contentDescription for those views in the code. 2024-05-20 11:59:13 +05:30
MohitMaliFtechiz
72d1ea3340 Introduced the ContentDescription lint check. 2024-05-20 11:59:06 +05:30
Kelson
95ef46adf5
Merge pull request #3849 from kiwix/Fix#3848
Fixed: Improve article search in our application.
2024-05-17 19:02:37 +02:00
MohitMaliFtechiz
412fdb97d3 Removed the commented code. 2024-05-17 18:12:28 +05:30
MohitMaliFtechiz
1df7a0b27a Fixed the application was crashing when we frequently searching and clicking on any article.
* Added test cases for testing this scenario.
2024-05-17 18:06:05 +05:30
MohitMaliFtechiz
e914b25957 Fixed the test cases that were failing if testPauseAndResumeInOtherLanguage failed due to any reason. Because the language remains changed and other test cases will fail. Like it was failed in this PR on API level 30.
* Also, improved our `DownloadTest`, because after changing the language of the application online content will change according to the new language so now we are using a generic approach for downloading the zim file.
2024-05-17 14:45:14 +05:30
MohitMaliFtechiz
6ad1172ac3 Fixed: Improve article search in our application.
* Now we are using the same `ZimFileReader` object to search the articles. It reduces the search timing and avoids unnecessary allocation of objects in memory.
* Refactored the `SearchViewModelTest` for this change.
* After this change there is some unused code so we have removed that from our application.
2024-05-17 14:45:14 +05:30
Kelson
e4924d8deb
Merge pull request #3846 from kiwix/Fix#3845
Fixed: application was crashing when starting the `kiwix server`.
2024-05-17 09:10:37 +02:00
MohitMaliFtechiz
e48e46b923 Fixed: application crashing when hosting the split zim files on server, since we have an issue with split zim files of zim-tools. Due to this issue, there is crash reported on the playStore. Because we have full access to files in the playStore variant since all the files are located in the app-specific directory.
* Improved the log for showing the actual error if there is something goes wrong while adding the book in `Library`.
2024-05-16 17:37:53 +05:30
MohitMaliFtechiz
17dac247c7 Improved the permission asking when the user tries to start the server in all variants and all versions of Android so that it will ask storage(read/write) permission for below Android 13 in non-playStore variant. Also, ask for the MANAGE_EXTERNAL_STORAGE permission in Android 11 and above. This check ensures that without the storage and MANAGE_EXTERNAL_PERMISSION user can not start the server. 2024-05-16 17:37:53 +05:30
MohitMaliFtechiz
a5fc8d9257 Fixed: A crash occurred when starting the kiwix server.
* Added a check for checking the `MANAGE_EXTERNAL_STORAGE` permission when starting the server in the non-playStore variant. If there is no permission, then it ask for the permission to avoid the crash due to permission lack for file.
2024-05-16 17:37:53 +05:30
Kelson
a155b62050
Merge pull request #3847 from kiwix/Fix#3666
Fixed: Unable to restart download after pausing.
2024-05-16 11:49:57 +02:00
MohitMaliFtechiz
680628f339 Fixed: Unable to restart download after pausing.
* It was due to we were using the hardcoded string for checking the pause state of downloading so pausing and resuming are working fine in the English version and do not work in other languages.
* Added test cases for checking this scenario so that we can avoid this type of errors in the future.
2024-05-16 11:45:20 +05:30
Kelson
56bd7419e7
Merge pull request #3844 from kiwix/Fix#3838
Uploading nightly APK with released signature.
2024-05-15 07:04:45 +02:00
MohitMaliFtechiz
ed0ffad86c Uploading nightly APK with released signature.
* Uploading nightly APK with a released signature so that APK can update, if a user downloads the new version of nightly like our released APK.
* Modified the nightly CI for this change.
2024-05-14 15:34:27 +05:30
Kelson
2612cf83a8
Merge pull request #3840 from kiwix/Fix#3783
Upgraded the minimum SDK version to `25`.
2024-05-13 16:27:13 +02:00
MohitMaliFtechiz
4256247afb Renamed the test cases according to our new minimum API level. 2024-05-13 18:41:52 +05:30
MohitMaliFtechiz
396e291028 Added the heap size in API level 25 emulator. 2024-05-13 18:06:36 +05:30
MohitMaliFtechiz
34928323d5 Updated minimum SDK version to 25.
* Updated the `README.md` file for this new change.
* Removed the API level 24 from CI and added the API level 25 since now our minimum SDK version is 25.
* Renamed CompatV24 file since we have upgraded the minimum SDK version so this fileName was irrelevant.
2024-05-13 13:03:21 +05:30
Kelson
c03c376ea1
Merge pull request #3835 from kiwix/update_changelog_for_3.10.1
Updated the CHANGELOG file for version `3.10.1`.
3.10.1
2024-05-10 12:22:47 +02:00
MohitMaliFtechiz
3a18fb389f Updated the CHANGELOG file for version 3.10.1.
* We have fixed some issues in this milestone which should be mentioned in the CHANGELOG file so we have added them in CHANGELOG file.
2024-05-10 15:44:40 +05:30
Kelson
e46e0dbe1e
Merge pull request #3834 from kiwix/Fix#3832
Fixed: Zim files are not opening with kiwix when clicking from the storage.
2024-05-10 12:13:27 +02:00
MohitMaliFtechiz
1b596ecb0d Added test cases for testing the deep linking in our application.
* Testing for both `file` and `content` scheme type uris.
2024-05-10 15:04:47 +05:30
MohitMaliFtechiz
31078e3dce Fixed: Zim files are not opening with kiwix when clicking from the storage.
* Corrected the deep linking for `content` type scheme.
* Improved the handling of zim files if user opens from the storage and our application is not in background.
* Improved the opening of Zim files when we open directly from storage.
* Also, added necessary comments on the changes to properly understand why we have done these changes.
2024-05-10 15:04:36 +05:30
Kelson
ab694c4f3d
Merge pull request #3824 from kiwix/Fix#3808
Fixed: PlayStore showing deep linking issue for URLs schema.
2024-05-10 07:34:59 +02:00
MohitMaliFtechiz
ffcfa9f837 Removed the URL type deep link since we are mainly using deep links for opening zim files in the application, and URLs type deep links are for downloading the content not for opening the ZIM files so we are removing these deep links from our application. 2024-05-09 21:09:58 +05:30
Kelson
4a1ac3a9b7
Merge pull request #3833 from kiwix/translatewiki
Localisation updates from https://translatewiki.net.
2024-05-09 15:33:50 +02:00
translatewiki.net
7bd39f0dfd Localisation updates from https://translatewiki.net. 2024-05-09 14:07:20 +02:00
Kelson
7ff9b25064
Merge pull request #3828 from kiwix/update_version_to_3.10.1
Updated kiwix version to `3.10.1`.
2024-05-08 16:59:24 +02:00
MohitMaliFtechiz
94dcebe25a Updated kiwix version to 3.10.1. 2024-05-08 16:59:08 +02:00
Kelson
642b86ee5e
Merge pull request #3829 from kiwix/update_changelog_file
Updated the CHANGELOG file for `3.10.1`.
2024-05-08 16:58:45 +02:00
MohitMaliFtechiz
9cca135b30 Updated the CHANGELOG file for 3.10.1. 2024-05-08 19:15:01 +05:30
Kelson
36d8ae9808
Merge pull request #3803 from kiwix/Issue#3605
Error on opening a split zim file on external storage.
2024-05-08 14:08:13 +02:00
MohitMaliFtechiz
ecf74ed803 Corrected the comment for handling the exception. 2024-05-08 14:07:47 +02:00
MohitMaliFtechiz
96debf9e53 Added test case for testing splitted zim file with zero size file. 2024-05-08 14:07:47 +02:00
MohitMaliFtechiz
c0912dee89 Simplified the creation of splitted zim file. 2024-05-08 14:07:47 +02:00
MohitMaliFtechiz
326b3901c4 Added comments if libzim throw exception for articleCount and mediaCount this will necessary to catch the all exception thrown by libzim to prevent the aborting of the rendering process of other zim files. 2024-05-08 14:07:47 +02:00
MohitMaliFtechiz
9cb881bf06 Capturing the better exception when getting the mediaCount and articleCount because it was throwing java.lang.Exception with splitted zim file when the zim file is corrupted. If there is any zim file is corrupted and libzim throws this exception then our UI will not show the other zim file on LocalLibraryScreen due to the getting zim files process being crashed. 2024-05-08 14:07:47 +02:00
MohitMaliFtechiz
b8971e1b64 Error on opening a split zim file on external storage.
* Added test cases for testing that the ZimFileReader can open the splitted zim file or not.
2024-05-08 14:07:47 +02:00
Kelson
07956ebfd2
Merge pull request #3826 from kiwix/Fix#3825
Fixed: The Delete icon is showing wrong content description on the notes and history screen.
2024-05-08 14:01:48 +02:00
MohitMaliFtechiz
4a5033fb7c Fixed: The Delete icon is showing wrong content description on the notes and history screen.
* Added correct description to delete button on HistoryFragment, and NotesFragment.
* Refactored the test case according to this new change.
* Sometimes actionOnItemAtPosition method gives an internal error, and does not perform the desired operation and fails the NoteFragmentTest. So we have moved it inside the testFlakyView method so that if there is any internal error occurs it retries this action.
2024-05-08 14:57:35 +05:30
Kelson
c663059d41
Merge pull request #3823 from kiwix/Fix#3813
Fixed: `Low contrast` issues reported by the playstore.
2024-05-07 15:24:40 +02:00
MohitMaliFtechiz
119fca00d3 Fixed, selecting language was not working because the clickable area became short due to our change because we have changed the height to wrap_content. 2024-05-07 18:03:13 +05:30
MohitMaliFtechiz
cf8093d259 Fixed: Low contrast issues reported by the playstore.
* Changed the background color of `ErrorActivity` and checkbox to resolve the issue.
* Added the background color in `IntroFragment` for resolving the issue, it is exact same design as previous.
* Changed the tint color of `ic_feedback_orange_24dp` image to resolve the low contrast issue.
* Changed the height of item_language item to wrap content instead of a fix height which prevent the expansion of layout if there is more content.
2024-05-07 16:11:29 +05:30
Kelson
4b575cf8b5
Merge pull request #3822 from kiwix/translatewiki
Localisation updates from https://translatewiki.net.
2024-05-07 09:37:35 +02:00
translatewiki.net
a09cc2dec4 Localisation updates from https://translatewiki.net. 2024-05-07 12:11:20 +05:30
Kelson
c29abd1b67
Merge pull request #3817 from kiwix/Fix#3809
Fixed: issue with front page of Zim on a USB stick loading.
2024-05-06 20:19:13 +02:00