7778 Commits

Author SHA1 Message Date
MohitMaliFtechiz
4b8dd0ec3b Fixed: issue with front page of Zim on a USB stick loading.
* Rectified the `ServiceWorkerUninitialiser` code to appropriately uninitialize the service worker. Previously, when the uninitializing code ran from the JavaScript interface, we directly called the function, which sometimes functioned correctly but sometimes did not. To address this inconsistency, we are now invoking that function to ensure the main page loads after the service worker is uninitialized.
* Rectified the syntax error in the `ServiceWorkerUninitialiser` JavaScript code, which was causing an issue on API level 24. Consequently, the main page failed to load on this API level. We've refactored our code to ensure compatibility across all API levels.
* Now that our service is functioning correctly, there's no need to explicitly load the main page. Upon service worker uninitialization, the main page automatically loads.
2024-05-06 20:12:53 +05:30
Kelson
c06194dfdc
Merge pull request #3821 from kiwix/java-libkiwix-2.1.1
Use java-libkiwix 2.1.1
2024-05-03 23:12:57 +02:00
Emmanuel Engelhart
11e5bb3ed4
Use java-libkiwix 2.1.1 2024-05-03 22:38:34 +02:00
Kelson
8c312685f3
Merge pull request #3818 from kiwix/Fix#3811
Fixed: `Touch target size` issue reported by the playstore.
2024-05-03 18:40:09 +02:00
MohitMaliFtechiz
284c1bf925 Fixed: Touch target size issue reported by the playstore.
* Fixed the touch target issue occurring in the HelpFragment screen. Added the `minWidth` and `minHeight`. For manintaing the current design we have done some modification in this screen like adding the padding and `scaleType` otherwise the design was looking very bigger then previous.
* Changed the width of `page_switch` to `wrapContent` instead of fixed width which prevents to expansion of the view if there is more content to display.
* Increase the height of SearchView's editText to resolve the `Touch target issue`.
* Added the minHeight for `deviceName` to touch target issue. Also, added the contentDescription for this textView.
* Moved the "Device Name" string to strings.xml file since it was hardcoded here.
* Added `minHeight` for showing link textView in external link popup.
2024-05-03 14:44:11 +02:00
Kelson
f55df2fa5b
Merge pull request #3820 from kiwix/Fix#3819
Fixed: Ci is continuously failing.
2024-05-03 14:43:53 +02:00
MohitMaliFtechiz
ad1cbeb7bc Deleting the test application before running the test cases. 2024-05-03 17:08:23 +05:30
MohitMaliFtechiz
ff9c82ebb8 Fixed: Ci is continuously failing.
* Modified the `instrumentation.sh` script to delete the app if already installed in the device before running the test cases.
2024-05-03 16:50:46 +05:30
Kelson
6656d94115
Merge pull request #3815 from kiwix/Fix#3810
Fixed: `Content labeling` issue reported by the playstore.
2024-04-30 18:37:28 +02:00
MohitMaliFtechiz
cb6c9e0f88 Fixed: Content labeling issue reported by the playstore.
* Added the content description for `send report` image, and fixed the sizing issues of `send feedback` and `send report` textView so that user can easily click on these views.
* Added content description for `File transfer list recyclerview`.
* There is only one accessibility warning left which is `Multiple items have the same description` it is because recyclerview items have the same content description and we can ignore this type of error because 2 views can have the same content description because their functionality can be same.
2024-04-30 21:35:18 +05:30
Kelson
c8f080f507
Merge pull request #3814 from kiwix/Fix#3812
Fixed `Implementation` issue reported by the playstore.
2024-04-30 18:00:59 +02:00
MohitMaliFtechiz
471337d506 Fixed Implementation issue reported by the playstore.
* Changed the width and height of `ic_tab_switcher_text` to  `wrapContent`  instead of fixed width and height which prevents to expand of the view if there is more content to display.
* To maintain the current design we have added the `minHeight` and `minWidth` for textView otherwise the background was showing very odd.
2024-04-30 18:29:29 +05:30
Kelson
281ce6f17e
Merge pull request #3807 from kiwix/Fix#3805
Fixed: Sometimes setting the `org.kiwix.libzim.Archive.setNativeArchive` crashes the application.
2024-04-30 10:07:52 +02:00
MohitMaliFtechiz
89a5a9ade5 Added the test cases, for testing the scenario where the zim file was not properly loading after opening the note on the notes screen to ensure that this functionality should work properly. 2024-04-30 12:19:35 +05:30
MohitMaliFtechiz
a246c932ad Removed the existBook method from KiwixReaderFragment sine we moved this in CoreReaderFragment.
* Improved the UI to not show the webView options for deleted zim files.
2024-04-29 19:33:44 +05:30
MohitMaliFtechiz
e193f10afd Fixed Search is not working in both modules.
* Fixed when we opens the `Note dialog` from Note screen and came back to reader screen then it was showing the blank screen.
2024-04-29 19:27:58 +05:30
MohitMaliFtechiz
010052a3a0 Fixed: Sometimes setting the org.kiwix.libzim.Archive.setNativeArchive crashes the application.
* We are now creating the ZimFileReader object on the background thread to not block the UI thread which sometimes causing the ANR because UI was frozen due to creation of ZimFileReader with large file.
* Refactored our functionality to support this new change.
* Refactored the test cases according to this functionality.
2024-04-26 19:16:09 +05:30
translatewiki.net
16048ed150 Localisation updates from https://translatewiki.net. 3.10.0 2024-04-26 15:16:10 +05:30
Kelson
183e2505b4
Merge pull request #3804 from kiwix/Update_changelog_file
Updated `CHANGELOG` file
2024-04-25 18:04:27 +02:00
MohitMaliFtechiz
5582718fe4 Updated CHANGELOG file since we have added some new fixes/improvements in milestone 3.10.0. 2024-04-23 17:08:43 +05:30
Kelson
c0588a816f
Merge pull request #3800 from kiwix/translatewiki
Localisation updates from https://translatewiki.net.
2024-04-23 08:02:00 +02:00
translatewiki.net
0a47a22301 Localisation updates from https://translatewiki.net. 2024-04-23 08:01:34 +02:00
Kelson
ccc92fb31e
Merge pull request #3798 from kiwix/Fix#2360
Added documentation for `Git Hooks` in the `CONTRIBUTING` file.
2024-04-23 07:45:30 +02:00
MohitMaliFtechiz
6c25f0d97c Added documentation for Git Hooks in CONTRIBUTING file. 2024-04-23 07:45:20 +02:00
Kelson
f53b656ab8
Merge pull request #3802 from kiwix/libkiwix-2.1.0
Use libkiwix-java 2.1.0
2024-04-22 20:33:12 +02:00
Emmanuel Engelhart
68dd59432c
Use libkiwix-java 2.1.0 2024-04-22 19:37:29 +02:00
Kelson
6f1a24829c
Merge pull request #3770 from kiwix/translatewiki
Localisation updates from https://translatewiki.net.
2024-04-19 08:02:36 +02:00
translatewiki.net
7b923ed371 Localisation updates from https://translatewiki.net. 2024-04-18 14:09:28 +02:00
Kelson
29c3962172
Merge pull request #3797 from kiwix/Fix#3796
Fixed: PlayStore reported IndexOutOfBoundsException, when we are selecting the item from rightDrawer.
2024-04-17 19:50:34 +02:00
MohitMaliFtechiz
5e9962b5a1 Fixed: PlayStore reported IndexOutOfBoundsException, when we are selecting the item from rightDrawer.
* The error is not reproducible on my device and emulators too. But playStore reported this error so somehow this error is occurring. So to fix this issue we are now only performing the click action when the item is available in the DocumentSectionsList. This will avoid this type of error.
2024-04-17 22:51:43 +05:30
Kelson
65591d26dd
Merge pull request #3793 from kiwix/Fix#3792
Fixed: Tabs are not restoring if we accidentally click twice on the Close all tabs button.
2024-04-17 19:05:31 +02:00
MohitMaliFtechiz
a96d5de33b Fixed: Tabs are not restoring if we accidentally click twice on the Close all tabs button.
* This issue occurred because when the Close all tabs button was first clicked, it closed all tabs and stored them into the temp list, emptying the main list. However, if the button was immediately clicked again, it would attempt to copy the main list to the temp list, which was already empty. To address this issue, we have disabled the button after the first click to prevent such situations, as they can occur due to accidental clicks.
* Enhanced the behavior of the "Tabs closed" snackBar. Now, when the user clicks the "UNDO" button to restore a tab, we disable the snackBar's "UNDO" button to prevent subsequent clicks. This prevents the addition of multiple tabs if the "UNDO" button is clicked multiple times, as such restored tabs can lead to unexpected behavior.
2024-04-17 18:35:47 +02:00
Kelson
236f695166
Merge pull request #3791 from kiwix/Fix#3790
Fixed: Play Store reported a crash error when closing the tabs.
2024-04-17 18:35:25 +02:00
MohitMaliFtechiz
40e86d02b6 Enhanced the Tab closed snackBar behavior. Now, when the user clicks the UNDO button to restore a tab, we disable the snackBar's "UNDO" button to prevent subsequent clicks. This prevents the addition of multiple tabs if the UNDO button is clicked multiple times, as this type of restored tab leads to unexpected behavior see below video. 2024-04-17 18:16:22 +02:00
MohitMaliFtechiz
dda2200a4b Fixed: Play Store reported a crash error when closing the tabs.
* This error was occurring due to the user frequently clicking the close icon of the same tab, in this situation first click closes the tab, and the second immediate click again triggers the `closeTab` function but recyclerView does not have the valid view for this position because it is in removing process so this makes this view invalid and recyclerView returns the `-1` index for invalid views. So this was the reason for this issue, to address this issue we have added a check in our `closeTab` method if the incoming index is `-1` then it will not execute the further code.
2024-04-17 18:16:22 +02:00
Kelson
cf745d3cad
Merge pull request #3795 from kiwix/Fix#3794
Fixed: PlayStore reported `UninitializedPropertyAccessException` when launching the `KiwixMainActivity`.
2024-04-17 18:15:46 +02:00
MohitMaliFtechiz
ebfea07fd4 Fixed: PlayStore reported UninitializedPropertyAccessException when launching the KiwixMainActivity.
* The error was occurring when launching the `KiwixMainActivity`. At this moment, `coreComponent` was in creation process so it is not initialized at this moment, and we are passing this component in our `KiwixMainActivity` through interface for injection of this activity. But we are not using `coreComponent` object in our `KiwixMainActivity` so passing it to the activity is unused because we are injecting this activity through `cachedComponent`, and this unused object causing the error. So we have removed this interface from our `BaseActivity` and directly injecting `KiwixMainActivity` in via `cachedComponent`.
2024-04-17 20:33:09 +05:30
Kelson
4ccaca5df5
Merge pull request #3786 from kiwix/Fixes#3784
Changing runner to `ubuntu-latest`.
2024-04-16 17:15:44 +02:00
MohitMaliFtechiz
b0caf69715 Changed the runner version to ubuntu-22.04. 2024-04-16 10:50:03 +05:30
MohitMaliFtechiz
30424518a8 Re-enabled the caching of avd. 2024-04-15 16:51:58 +05:30
MohitMaliFtechiz
d0cf899009 Add heap-size to emulator. Also, set to not force create the avd when running the test cases. 2024-04-15 16:51:51 +05:30
MohitMaliFtechiz
fa5e1cfc82 Changing runner to ubuntu-latest.
* Changed the runner of CI to `ubuntu-latest` to boost the performance.
*  Enabled the `fail-fast` option in CI, if any of jobs fail on any emulator then it will cancel the all jobs running on other emulators in the current process so that other PRs do not need to wait to finish this job. Also, this will reduce the running timing on CI since if a job fails on any emulator we need to fix that so running others jobs does not make sense. So we are canceling those jobs if any fail.
* Introducing caching for AVD to run test cases faster. It will reduce emulator boot time.
* Changed emulator configurations for the 'ubuntu-latest' runner. Removed the 'disk-size' option since it was throwing an error, causing the emulator not to boot. Also, reduced the SD card size to 2GB from 4GB.
* Reduced the SD card size to 2GB from 4GB.
2024-04-15 16:51:44 +05:30
Kelson
735bf1caa3
Merge pull request #3789 from kiwix/polish-readme
Small refresh of the README.md
2024-04-13 15:25:59 +02:00
Emmanuel Engelhart
59531677d5
Small refresh of the README.md 2024-04-13 15:24:28 +02:00
Kelson
5e3a5661e0
Merge pull request #3788 from kiwix/codecov-token
Add CODECOV_TOKEN
2024-04-12 20:10:04 +02:00
Emmanuel Engelhart
4ed3511660
Add CODECOV_TOKEN 2024-04-12 18:43:48 +02:00
Kelson
ef9fcd6ee9
Merge pull request #3785 from kiwix/fix_allocate_buffers_on_ci
Fixed allocate_buffer_size on CI.
2024-04-12 17:58:13 +02:00
MohitMaliFtechiz
1251dc403e Improved KiwixSplashActivityTest which failed once on CI. 2024-04-12 20:33:06 +05:30
MohitMaliFtechiz
3a0054e97d Improved ZimHostFragmentTest which sometimes unable to find the "PROCEED" button. 2024-04-12 18:11:33 +05:30
MohitMaliFtechiz
8c72d404bb Improved the systemDialog checking method, Last CI was failed due to a system dialog is visible but with some different title so closing the system dialog code does not work. So we have improved a bit this method because most of the system dialog have the "WAIT","Wait","OK" or "Ok" button in it. 2024-04-12 17:51:12 +05:30