8455 Commits

Author SHA1 Message Date
MohitMaliFtechiz
8527e2070d Improved the naming of constant variables to "SCREAMING_SNAKE_CASE," which is our default naming convention for constants.
* Fixed some other ktlint issues.
2025-02-24 12:42:31 +05:30
MohitMaliFtechiz
6721be1764 Upgraded detekt and ktlint libraries to latest version. 2025-02-21 19:05:43 +05:30
Kelson
102162fde3
Merge pull request #4227 from kiwix/Fixes#4226
Removed the uploading of unnecessary files in the release.
2025-02-16 09:42:14 +01:00
MohitMaliFtechiz
6ac9c5ef75 Removed the uploading of unnecessary files in the release.
* Now, only APK files will be uploaded in the release.
2025-02-14 11:34:31 +05:30
Kelson
f6aef1b7ea
Merge pull request #4219 from kiwix/translatewiki
Localisation updates from https://translatewiki.net.
3.14.0
2025-02-13 14:41:51 +01:00
translatewiki.net
262e327f20 Localisation updates from https://translatewiki.net. 2025-02-13 14:41:40 +01:00
Kelson
f9c164556e
Merge pull request #4225 from kiwix/Fixes#4224
Fixed: Opening SearchItem and FindInPage triggers again when switching back to the reader fragment.
2025-02-13 14:41:19 +01:00
MohitMaliFtechiz
5e74d626d0 Fixed: Opening SearchItem and FindInPage triggers again when switching back to the reader fragment.
* The issue occurred because when moving to another fragment, the `ReaderScreen` remained in the backstack and was not fully destroyed along with its data. Additionally, we were storing the `SearchItem` and `FIND_IN_PAGE` query in variables to perform these actions after restoring tabs. As a result, when reopening the `ReaderScreen`, the tabs were restored, and these variables retained their values, triggering the related actions again.
* To fix this, we have cleared these variables when the fragment is destroyed, as keeping them is unnecessary when the user navigates away from the reader screen.
2025-02-13 18:03:49 +05:30
Kelson
2017a4ea9e
Merge pull request #4218 from kiwix/Fixes#4216
Fixed: Kiwix cannot import ZIM files from the filesystem.
2025-02-13 10:27:07 +01:00
MohitMaliFtechiz
4735933fd5 Refactored the FileUtilsInstrumentationTest. 2025-02-13 10:26:37 +01:00
MohitMaliFtechiz
d974822481 Refactored the deprecated method used in our test cases. 2025-02-13 10:26:37 +01:00
MohitMaliFtechiz
6cdc8f23d4 Improved USB and External Hard Drive Path Retrieval for Android 10 and Above.
* The getExternalFilesDirs method only returns the USB path for devices running Android 9 (API 28) and below.
* On Android 10 (API 29) and above, this method returns null when accessing external storage like USB sticks.
* To work around this limitation, we previously appended the /mnt/media_rw/ path manually. While this worked in most cases, it was unreliable across different devices, as the mounted path could vary.
* To ensure accurate retrieval of external storage paths, we have switched to the StorageService API.
* This API, introduced in Android 11 (API 30), directly provides the actual mount paths for all external storage devices, including SD cards, USB sticks, and external hard drives.
* For Android 9 and below, getExternalFilesDirs continues to work as expected, so we use it where applicable.
* This improvement ensures that USB and SD card paths are retrieved correctly on modern Android devices.
* Added debugging logs to capture errors when opening a file in the reader.
* These logs will help us diagnose issues when users share a diagnostic report.
2025-02-13 10:26:37 +01:00
MohitMaliFtechiz
e6f378e165 Fixed: notifyFileOperationSuccess should handle invalid ZIM file unit test case. 2025-02-13 10:26:37 +01:00
MohitMaliFtechiz
496ddf1ea0 Updated the tarask string file 2025-02-13 10:26:37 +01:00
MohitMaliFtechiz
ae8974d682 Fixed: Kiwix cannot import ZIM files from the filesystem.
* Displaying a proper error message with the full ZIM path when there is an issue opening the ZIM file or if the selected file is not a valid ZIM file.
* Refactored `CopyMoveFileHandlerTest` to align with this change.
* Updated the documentation to help translators understand this update.
* To resolve the lint error, all string files have been updated. These files will be automatically updated in the latest TranslateWiki PR.
2025-02-13 10:26:37 +01:00
Kelson
50eeeecade
Merge pull request #4221 from kiwix/update_changelog_for_3.14.0
Updated the `CHANGELOG` file for milestone `3.14.0` to include the remaining changes made in this milestone.
2025-02-13 10:26:04 +01:00
MohitMaliFtechiz
15bb7d8de6 Updated the CHANGELOG file for milestone 3.14.0 to include the remaining changes made in this milestone. 2025-02-13 10:25:36 +01:00
Kelson
e1eafa1ddd
Merge pull request #4220 from kiwix/Fixes#4205
Fixed: When devices went to sleep mode, the search filter was reset of the online library.
2025-02-13 10:25:17 +01:00
MohitMaliFtechiz
cd67d4060e Added OnlineLibraryFragmentTest instrumentation (UI) test case to test this new functionality. 2025-02-11 17:44:34 +05:30
MohitMaliFtechiz
ec132e6d7f Fixed: When devices went to sleep mode, the search filter was reset of the online library.
* Preserved search query across lifecycle changes to restore it when the fragment becomes visible again.
* Previously, when the device went to sleep, `viewLifecycleOwner` closed the search view due to lifecycle events, resetting the search.
* Now, the query is stored in `ViewModel` (which is lifecycle-aware) and restored when the online library screen is reopened.
* Search is reset only when the user explicitly clears it.
2025-02-11 15:32:57 +05:30
Kelson
a88884a055
Merge pull request #4209 from kiwix/translatewiki
Localisation updates from https://translatewiki.net.
2025-02-08 09:19:04 +01:00
translatewiki.net
f1e1ccf716 Localisation updates from https://translatewiki.net. 2025-02-08 09:18:41 +01:00
Kelson
51aca061b9
Merge pull request #3996 from Saifuddin53/Issue#398
Saving and Restoring the Web View Navigation History Across Sessions
2025-02-08 09:17:43 +01:00
MohitMaliFtechiz
c29997aa12 Fixed: Opening a searched item and "Find in Page" was not working after rebasing.
* Removed unnecessary code from the project to simplify it and make it more robust.
2025-02-07 22:32:19 +05:30
MohitMaliFtechiz
3f80e9d852 Added debug logs which will help us in debugging if any error happens. 2025-02-07 13:51:29 +05:30
MohitMaliFtechiz
fe3597aa7b Fixed: Application crashes at first launch. 2025-02-07 13:50:59 +05:30
MohitMaliFtechiz
af8ca7f620 Fixed: SearchFragmentTest for custom apps was failing. 2025-02-07 13:50:48 +05:30
MohitMaliFtechiz
8a124d82ac Fix: Main page of ZIM file not loading when opening a note in the notes screen
* Resolved the issue where the main page of the ZIM file was not loading when a note was opened from the notes screen, when a different ZIM file was set in the reader. Now, when opening notes, the application correctly sets the corresponding ZIM file in the reader, ensuring the main page is displayed as expected.
2025-02-07 13:45:27 +05:30
MohitMaliFtechiz
5a47a7ba94 Fixed: Reader screen was showing twice when pressing the back button after opening a page from the history, bookmarks, or notes screens in custom apps. 2025-02-07 13:38:09 +05:30
MohitMaliFtechiz
d3f40f2219 Improved the saving of tabs. 2025-02-07 13:37:36 +05:30
MohitMaliFtechiz
83337ac5f1 Fixed: FindInPage functionality not working in Kiwix and custom apps. 2025-02-07 13:37:20 +05:30
MohitMaliFtechiz
67111ef848 Fixed: Searched item was not opening in custom apps. 2025-02-07 13:34:04 +05:30
MohitMaliFtechiz
2fb1896cea Fixed: Restore web view history in Kiwix app.
* Improved restoration of web view history after opening a searched article.
* Refactored `restoreViewStateOnValidJSON` and `restoreViewStateOnInvalidJSON` methods to save and retrieve web view history from the Room database.
* Added detailed comments to methods for better understanding, including guidance for developers to check subclass implementations before making modifications.
* Fixed the `static analysis` errors.
2025-02-07 13:29:01 +05:30
MohitMaliFtechiz
ee50417154 Implemented new approach to save and retrieve the webView history. 2025-02-07 13:28:33 +05:30
MohitMaliFtechiz
1e9dfd1531 Fixed detekt issue. 2025-02-07 12:47:22 +05:30
Saifuddin
5390c98d83 Naming conventions improved and some reviewed changes 2025-02-07 12:47:10 +05:30
Saifuddin
4cdd449564 Updated room schema 2025-02-07 12:46:57 +05:30
Saifuddin
a4c6070eab Automated changes reverted 2025-02-07 12:44:55 +05:30
Saifuddin
0d13e5b559 Automated changes reverted 2025-02-07 12:44:34 +05:30
Saifuddin
cdf22a56f5 Code factor improvements 2025-02-07 12:44:22 +05:30
MohitMaliFtechiz
b81e4b5c97 Naming convention improved 2025-02-07 12:44:11 +05:30
MohitMaliFtechiz
775d9439f3 Fixed the detekt issue 2025-02-07 12:42:05 +05:30
Saifuddin
5a7dc92e2c Restoring the internal webbackforwardlist 2025-02-07 12:41:54 +05:30
MohitMaliFtechiz
64f1bc47e0 Retrieving page history from room 2025-02-07 12:41:37 +05:30
MohitMaliFtechiz
a6d5ef0636 Saved webbackforwardlist to room 2025-02-07 12:41:27 +05:30
Kelson
687fbe0516
Merge pull request #4212 from kiwix/remaining_changelog_updates_for_3.14.0
Updated the `CHANGELOG` file to include the remaining changes made in milestone `3.14.0`.
2025-02-07 01:17:40 +01:00
MohitMaliFtechiz
3ee80ab645 Added a last fix made in milestone 3.14.0. 2025-02-07 01:17:19 +01:00
MohitMaliFtechiz
dec89e3058 Updated the CHANGELOG file to include the remaining changes made in milestone 3.14.0. 2025-02-07 01:17:19 +01:00
Kelson
a2341ba94b
Merge pull request #4214 from kiwix/Fixes#4213
Fixed: `Input dispatching timed out` error while creating the application shortcuts.
2025-02-07 01:16:47 +01:00
MohitMaliFtechiz
7474d7ef9a Fixed: Input dispatching timed out error while creating the application shortcuts.
* Moved shortcut creation to `lifecycleScope` with `Dispatchers.IO` to free up the main thread.
* This ensures the UI remains responsive while shortcuts are being created.
2025-02-07 01:16:32 +01:00