8455 Commits

Author SHA1 Message Date
Kelson
549bb5afb0
Merge pull request #4211 from kiwix/Fixes#4206
Keeping the downloading books always at the top.
2025-02-07 01:15:52 +01:00
MohitMaliFtechiz
08f7751be6 Fixed: The DownloadTest was failing. 2025-02-06 12:48:38 +05:30
MohitMaliFtechiz
a3341fc280 Refactored the ZimManageViewModelTest according to this new change. 2025-02-06 11:54:41 +05:30
MohitMaliFtechiz
079dd2f3c1 Added the "Downloading:" section title in string file. 2025-02-06 11:54:41 +05:30
MohitMaliFtechiz
7c969fe31d Keeping the downloading books always at the top.
* Added a new "Downloading:" section in `OnlineFragment` to display currently downloading books at the top.
* The language, and search filter will not affect this meaning if a user selects another language and searches any ZIM file via the search feature, the "Downloading:" section always shows on the top and the filter will be applied to the remaining books.
2025-02-06 11:54:41 +05:30
Kelson
c1a3b2bc40
Merge pull request #4210 from kiwix/Fixes#4207
Fixed: Download notification disappears when pausing a download.
2025-02-06 06:49:05 +01:00
MohitMaliFtechiz
6d407fcfa8 Removed the again showing the notification if user cancels it, and improved the setting of foreground notification when all other downloads are paused. 2025-02-05 18:35:32 +05:30
MohitMaliFtechiz
0646a782ab Fixed: Download notification disappears when pausing a download.
* The Fetch library automatically removes the ongoing download notification when a download is paused. To improve the user experience, we have implemented custom logic to display a notification for paused downloads, allowing users to easily resume them.
* Additionally, Android 14 introduces a change that prevents non-dismissible notifications. This means users can now dismiss notifications by swiping left or right. Since our app uses a foreground service for downloads, we must always display a notification. To handle this, we have implemented a mechanism that detects when a paused download notification is dismissed. If the download is still in a paused state, the notification will be re-displayed to ensure users can resume their downloads.
2025-02-05 17:23:15 +05:30
Kelson
256896fd49
Merge pull request #4208 from kiwix/readme_playstore_link_not_working
Minor improvement in showing the directory path in README file.
2025-02-05 12:17:32 +01:00
MohitMaliFtechiz
5b7a3af657 Minor improvement in showing the directory path in README file. 2025-02-05 15:49:55 +05:30
Kelson
81b730e280
Merge pull request #4193 from anupulu/patch-1
Update README.md
2025-02-01 12:13:36 +01:00
Anu
3a8bde4c38 Update README.md
Added emojis, clarified wording, etc.
2025-02-01 12:12:55 +01:00
Kelson
d23e536682
Merge pull request #4202 from kiwix/translatewiki
Localisation updates from https://translatewiki.net.
2025-02-01 12:10:42 +01:00
translatewiki.net
376c4d694d Localisation updates from https://translatewiki.net. 2025-02-01 12:10:30 +01:00
Kelson
6e3ceacd26
Merge pull request #4201 from kiwix/Fixes#4200
Fixed: `FIND_IN_PAGE` feature only works with first tab page.
2025-02-01 12:09:52 +01:00
MohitMaliFtechiz
a9364d5881 Fixed: The SearchFragmentTestForCustomApp was failing sometimes. 2025-02-01 12:07:02 +01:00
MohitMaliFtechiz
499ea74048 Fixed: FIND_IN_PAGE not working in tabs other than the first one.
* Improved the logic for handling search-related operations to ensure they are performed after tabs are fully restored.
* Previously, the search observation was initiated before the tabs were restored, causing the `FIND_IN_PAGE` feature to only work in the first tab. This happened because the webView list was empty at the time of observation.
* With the ZIM file opening and tab restoration now moved to background threads, the search observation logic has been moved to after the tabs are restored. This ensures that all webViews are properly initialized before observing search actions.
* This approach is more robust and aligns with the correct lifecycle of tab restoration and search functionality.
2025-02-01 12:07:02 +01:00
MohitMaliFtechiz
6604875bde Refactored the deprecated method used in app module test cases. 2025-02-01 12:07:02 +01:00
MohitMaliFtechiz
5e05fe81d9 Added test cases for custom apps to cover this scenario and prevent future errors.
* Refactored some deprecated methods used in test cases.
2025-02-01 12:07:02 +01:00
MohitMaliFtechiz
1ed02e5ab0 Fixed: FIND_IN_PAGE feature only works with first tab page.
* The previously loaded article was not loading in custom apps when switching to another fragment and then returning to the reader screen. Instead, the home page of the ZIM file was loading. A fix has been implemented to resolve this issue.
2025-02-01 12:07:02 +01:00
Kelson
a6a38438ad
Merge pull request #4197 from kiwix/Fixes#4196
Fixed: The bottom bar disappears when reopening the app from the background.
2025-02-01 12:06:42 +01:00
MohitMaliFtechiz
b573fe4040 Fixed: The bottom bar disappears when reopening the app from the background.
* The issue was that we were setting the bottom margin to `0` when the fragment was moved to the background (i.e., when switching fragments) to prevent the bottom margin from affecting other screens. This was applied to the `NavHostContainer`, which hosts the reader fragment. Enabling the bottom margin when the fragment view is created worked in most cases. However, on Android 15, the system saves the fragment state and does not recreate the view, which means our margin-setting logic was not executed. As a result, the `bottomAppBar` appeared to disappear, but in reality, it was rendering behind the `BottomNavigationView` (the three options at the bottom).
* To fix this, we now set the bottom margin in the `onResume` method so that whenever the reader screen becomes visible, the bottom margin is automatically adjusted.
2025-01-31 15:33:28 +01:00
Kelson
e61e3e8347
Merge pull request #4195 from kiwix/Fixes#4194
Fixed: When a note is deleted, the corresponding file remained in storage.
2025-01-31 15:32:42 +01:00
MohitMaliFtechiz
561af8f735 Added UI test cases for testing these both scenarios. 2025-01-31 12:49:59 +01:00
MohitMaliFtechiz
73ea170b03 Fixed: When a note is deleted, the corresponding file remained in storage.
* The note file is now deleted from storage when the user selects multiple notes and deletes them from the "Notes" screen.
* Improved note deletion in the "Note Dialog." Previously, when deleting a note from the `AddNoteDialog` on the Notes screen, the file was removed from storage, but its entry remained in the database, causing the note to still appear on the "Notes" screen after deletion. This issue has now been fixed.
2025-01-31 12:49:59 +01:00
Kelson
3da8c407c2
Merge pull request #4199 from kiwix/Fixes#4198
Fixed: Search was not working when closing a tab and immediately opening the search screen.
2025-01-31 12:49:18 +01:00
MohitMaliFtechiz
8be4029e0e Fixed: Search was not working when closing a tab and immediately opening the search screen.
* The issue occurred because, after closing a tab and quickly navigating to the search screen, the snackbar callback was still running in the background. When switching to the search screen, the WebView list was empty because we clear it when the fragment's view is destroyed. As a result, the book was closed, and the SearchScreen could not find the ZIM file for searching.
* To fix this, we now dismiss the snackbar callback when the fragment's view is destroyed.
2025-01-31 11:10:00 +01:00
Kelson
553fc44512
Merge pull request #4204 from kiwix/Fixes#4203
Bumped the `upload-artifact` action from version 3 to version 4.
2025-01-31 11:09:11 +01:00
MohitMaliFtechiz
1690a76275 Bumped the upload-artifact action from version 3 to version 4.
* The CI pipeline was failing due to the deprecated version of `upload-artifact` (v3).
* Upgrading to version 4 resolves the deprecation error and ensures compatibility with the latest features and improvements.
2025-01-31 14:51:22 +05:30
Kelson
734638356f
Merge pull request #4192 from kiwix/update_changelog_file_for_3.14.0
Updated the `CHANGELOG` file to show changes made in milestone `3.14.0`.
2025-01-28 11:01:44 +01:00
MohitMaliFtechiz
8687cb6a29 Updated the CHANGELOG file to show changes made in milestone 3.14.0. 2025-01-28 14:59:09 +05:30
Kelson
0000cdd7d5
Merge pull request #4191 from kiwix/update_kiwix_version_to_3.14.0
Upgraded the kiwix version to `3.14.0`.
2025-01-28 09:01:28 +01:00
MohitMaliFtechiz
6946dceeda Upgraded the kiwix version to 3.14.0. 2025-01-28 09:01:14 +01:00
Kelson
31f95fca67
Merge pull request #4190 from kiwix/Fixes#3956
Using java-libkiwix `2.2.4` to fix native crashes happens while getting the `getEntryByPath`, and `getData()` methods.
2025-01-28 09:00:41 +01:00
MohitMaliFtechiz
2746533375 Using java-libkiwix 2.2.4 to fix native crashes happens while getting the getEntryByPath, and getData() methods. 2025-01-28 11:41:21 +05:30
Kelson
773de4bfd4
Merge pull request #4187 from kiwix/translatewiki
Localisation updates from https://translatewiki.net.
2025-01-27 19:55:56 +01:00
translatewiki.net
732b83ac6c Localisation updates from https://translatewiki.net. 2025-01-27 14:24:17 +01:00
Kelson
8bd23938bc
Merge pull request #3937 from CalebKL/task/anr-fix-zimfile-reader
Task/anr fix zimfile reader
2025-01-27 14:17:51 +01:00
MohitMaliFtechiz
053b6e0937 Improved the getting bookmarks for current book. 2025-01-27 12:17:06 +05:30
MohitMaliFtechiz
b1c065882d Made the convertToBookOnDisk method suspend, as it creates the ZimFileReader object to convert the files into Books.
* Refactored the `StorageObserverTest` to align with this new change.
2025-01-27 12:17:06 +05:30
MohitMaliFtechiz
2f5da0ea3e Reverted the changes of showing the progress while opening the notes in note screen since now we are not creating the ZimFileReader on note screen. 2025-01-27 12:16:08 +05:30
MohitMaliFtechiz
45c74af742 Fixed: All unit test cases. 2025-01-27 12:14:28 +05:30
MohitMaliFtechiz
0d18419f7a Fixed: Links not working in restored tabs after closing all tabs and restoring them.
* Improved the tab closing and restoring process. Previously, when the user closed all tabs, the `ZimFileReader` was set to null. If the user restored the tabs, a new `ZimFileReader` was created, which was a resource-intensive operation, especially for large ZIM files.
* Now, the `ZimFileReader` is not set to null while the "restore tab" snackbar is visible, allowing users to restore tabs without recreating the ZimFileReader.
* Once the snackbar is dismissed, the `ZimFileReader` is set to null to free up resources since it is no longer required.
2025-01-27 12:13:52 +05:30
MohitMaliFtechiz
c9895206ed Added loading functionality to the notes dialog. 2025-01-27 12:13:39 +05:30
MohitMaliFtechiz
a181198079 Refactore code to not set the ZimFileReader when restoring the tabs since the ZIM file is already set in the reader 2025-01-27 12:12:29 +05:30
MohitMaliFtechiz
dd5a459d32 Creating the reader in lifecycleScope 2025-01-27 12:12:10 +05:30
MohitMaliFtechiz
9d4db58ce4 Suspended setZimReaderSource and switched to IO when creating ZimFileReader 2025-01-27 12:10:39 +05:30
Kelson
948b8cce20
Merge pull request #4189 from kiwix/Fixes#4184
Fixed: Navigation drawer showing while reading a book in fullscreen mode.
2025-01-26 22:16:35 +01:00
MohitMaliFtechiz
22a3b4d9d2 Fixed: Navigation drawer showing while reading a book in fullscreen mode.
* Disabled the right drawer when the user is reading a book in fullscreen mode to ensure uninterrupted reading.
* Also disabled the drawer while a video is playing in fullscreen mode to avoid interruptions during video playback.
2025-01-26 21:07:51 +01:00
Kelson
99aae9441b
Merge pull request #4186 from kiwix/Fixes#4185
Fixed: If storage permission is permanently denied on Android 11 or below, the selected file via the file picker does not open.
2025-01-26 21:07:24 +01:00