be clear about which pointer we get (instead of 'auto')

This commit is contained in:
Alexander Sashnov 2021-02-13 02:38:52 +07:00
parent ab83c930ef
commit f576df02fd
3 changed files with 7 additions and 7 deletions

View File

@ -155,8 +155,8 @@ void SearchBar::updateCompletion()
{ {
mp_typingTimer->stop(); mp_typingTimer->stop();
clearSuggestions(); clearSuggestions();
auto currentWidget = KiwixApp::instance()->getTabWidget()->currentWebView(); WebView* current = KiwixApp::instance()->getTabWidget()->currentWebView();
if (!currentWidget || currentWidget->url().isEmpty() || m_searchbarInput.isEmpty()) { if (!current || current->url().isEmpty() || m_searchbarInput.isEmpty()) {
hideSuggestions(); hideSuggestions();
return; return;
} }

View File

@ -13,10 +13,10 @@ void SuggestionListWorker::run()
QStringList suggestionList; QStringList suggestionList;
QVector<QUrl> urlList; QVector<QUrl> urlList;
auto currentWidget = KiwixApp::instance()->getTabWidget()->currentWebView(); WebView *current = KiwixApp::instance()->getTabWidget()->currentWebView();
if(!currentWidget) if(!current)
return; return;
auto qurl = currentWidget->url(); auto qurl = current->url();
auto currentZimId = qurl.host().split(".")[0]; auto currentZimId = qurl.host().split(".")[0];
auto reader = KiwixApp::instance()->getLibrary()->getReader(currentZimId); auto reader = KiwixApp::instance()->getLibrary()->getReader(currentZimId);
QUrl url; QUrl url;

View File

@ -55,9 +55,9 @@ TabBar::TabBar(QWidget *parent) :
setCurrentIndex(m_settingsIndex); setCurrentIndex(m_settingsIndex);
return; return;
} }
auto index = currentIndex() + 1; int index = currentIndex() + 1;
m_settingsIndex = index; m_settingsIndex = index;
auto view = KiwixApp::instance()->getSettingsManager()->getView(); SettingsManagerView* view = KiwixApp::instance()->getSettingsManager()->getView();
mp_stackedWidget->insertWidget(index, view); mp_stackedWidget->insertWidget(index, view);
insertTab(index,QIcon(":/icons/settings.svg"), gt("settings")); insertTab(index,QIcon(":/icons/settings.svg"), gt("settings"));
QToolButton *tb = new QToolButton(this); QToolButton *tb = new QToolButton(this);