790 Commits

Author SHA1 Message Date
Matthieu Gautier
42feaa9ac5
Merge pull request #807 from kiwix/translatewiki 2022-03-04 15:34:07 +01:00
translatewiki.net
bb121d93ea Localisation updates from https://translatewiki.net. 2022-03-03 13:06:06 +01:00
Kelson
bfbba8d9fd
Merge pull request #800 from kiwix/monitor-fix
Fix for monitor directory on Windows
2022-02-25 17:55:03 +01:00
Nikhil Tanwar
fac7065c5d
Use native separators in settings panel
Adds functionality to use native separators, to follow Windows standards
2022-02-25 17:54:20 +01:00
Nikhil Tanwar
70e13865aa
Remove save() from load monitor dir
Calling save() from loadMonitorDir() can cause the file watcher (when connected to same directory as download directory) to listen to directoryChanged signal, and going into an infinite loop.
We already call save() in the library destructor, hence no functionality is compromised.
2022-02-25 17:54:19 +01:00
Nikhil Tanwar
2b62e42c55
Fix wrong path creation
The previous implementation lead to a path like: dir1/dir2/dir3\dir4 on windows
2022-02-25 17:54:19 +01:00
Matthieu Gautier
cdc0193522
Merge pull request #798 from kiwix/fix_content_type_filtering 2022-02-25 16:57:48 +01:00
Matthieu Gautier
f053ded6f8 Fix content-type filtering
The commit cb63bb2 was buggy and deactivate filtering by contentType.
We now handle two different lists to store tags we want and tags we don't.
2022-02-25 16:48:26 +01:00
translatewiki.net
7268d7b15a
Localisation updates from https://translatewiki.net. (#790) 2022-02-25 16:24:38 +01:00
Kelson
d483c1abca
Merge pull request #799 from kiwix/paddingFix 2022-02-25 14:16:20 +01:00
Nikhil Tanwar
cea8c2656d Remove padding from QSpinbox
This removes an explicit padding from QSpinbox. QSpinbox will now have the default padding (if any) for QSpinbox.
Helps the text to not disappear at some systems/configurations
To keep the previous design changes QLabel padding to 12px (top and bottom) and 8px (right and left)
2022-02-25 17:39:56 +05:30
Kelson
09a0259554
Merge pull request #774 from kiwix/zoomSearchFix
set zoom factor after page has finished loading
2022-02-25 12:37:37 +01:00
Nikhil Tanwar
be0901a8b1 set zoom factor after page has finished loading
This fixes the problem of page not getting the correct zoom factor (after accessing an article from searchbar)
Now, the zoom factor is set again after page has completely finished loading
2022-02-25 15:20:10 +05:30
Kelson
5df09ee259
Merge pull request #795 from kiwix/remove-ft-filtering 2022-02-15 18:44:39 +01:00
Emmanuel Engelhart
f40899f128
Remove ft filtering in library 2022-02-15 16:33:42 +01:00
Kelson
969746913f
Merge pull request #791 from kiwix/fix_other_filtering
Correctly set the "acceptTags" when we filter by tags.
2022-02-14 20:09:56 +01:00
Matthieu Gautier
cb63bb2d01 Correctly set the "acceptTags" when we filter by tags.
In case of "other" filter, we were setting the filter with
`filter.rejectTags(tags)` and `filter.acceptTags(tags)` in the same time.
Which obviously return 0 results.

We must call `filter.acceptTags(tags)` only if we use a specific category,
not all the time (including with "other" category).

Fix #786
2022-02-14 17:31:21 +01:00
Kelson
8551bcffde
Merge pull request #789 from kiwix/remove-codefactor-issues
Remove a few Codefactor silly errors
2022-02-13 20:11:42 +01:00
Emmanuel Engelhart
3e3346c09d
Shorten CSS rule 2022-02-13 14:06:10 +01:00
Emmanuel Engelhart
00c9b35526
Remove empty line 2022-02-13 14:04:14 +01:00
Emmanuel Engelhart
b4e82dd7ad
Remove empty line 2022-02-13 14:03:06 +01:00
Emmanuel Engelhart
62d0b4a091
Replace CSS 0pt by 0 2022-02-13 13:36:03 +01:00
Emmanuel Engelhart
c24636772c
Remove a few empty lines for codefactor 2022-02-13 13:35:18 +01:00
Emmanuel Engelhart
fba7e94a33
Simplify CSS rule 2022-02-13 13:32:14 +01:00
Emmanuel Engelhart
529f549af1
No need of semi-colon after function declaration 2022-02-13 13:26:54 +01:00
Emmanuel Engelhart
5daab5e0f9
Replace CSS value 0px by just 0 2022-02-13 13:24:21 +01:00
Emmanuel Engelhart
4894289092
Shorter CSS margin declaration 2022-02-13 13:22:36 +01:00
Emmanuel Engelhart
2c9f7c1f2a
Bad CSS property name 2022-02-13 13:21:03 +01:00
Kelson
d6592956e7
Merge pull request #787 from kiwix/translatewiki
Localisation updates from https://translatewiki.net.
2022-02-10 13:49:25 +01:00
translatewiki.net
9ed2f67099 Localisation updates from https://translatewiki.net. 2022-02-10 13:05:46 +01:00
Kelson
df2a95273a
Merge pull request #743 from kiwix/monitorDirectory
Enable directory monitoring for new zims
2022-02-08 21:25:49 +01:00
Nikhil Tanwar
5e9aa63b45
Add real-time library monitoring
Adds a QFileSystemWatcher to watch over monitor directory.
Everytime directoryChange is emitted, it calls asyncLoadMonitorDir
2022-02-08 21:08:26 +01:00
Nikhil Tanwar
e0337d0caf
Refresh library with monitory directory changes on startup
This refreshes the library on every startup
list of elements already in monitor directory (before changes) are taken by filtering library.xml
2022-02-08 21:08:25 +01:00
Nikhil Tanwar
45a09cfae6
Add logic to refresh library with monitor directory changes
To check if there have been any changes in monitor directory, we compare the files before and after followed by adding/removing them from the library
2022-02-08 21:08:25 +01:00
Nikhil Tanwar
a69e6a1f02
Add monitor directory entry in settings panel
This adds an option to check/update monitor directory from the settings panel.
2022-02-08 21:08:25 +01:00
Nikhil Tanwar
8d6d6833e7
Make SettingsManager::setDownloadDir a void function
The current implementation doesn't have any effect on it being a bool
2022-02-08 21:08:24 +01:00
Nikhil Tanwar
a887af01be
Add generalised confirm function and use it in confirmDialogDownloadDir
This adds a new method confirmDialog(QString, QString) as a generalised function for confirm boxes
confirmDialogDownloadDir is changed to use this new method
2022-02-08 21:08:24 +01:00
Nikhil Tanwar
52ff3afaec
Move getters in settingsmanager out of slots and make them const
This changes the following getters:
getKiwixServerPort()
getKiwixServerIpAddress()
getZoomFactor()
getDownloadDir()
2022-02-08 21:08:24 +01:00
Nikhil Tanwar
324ffbb326
Improve const correctness in Library
This makes getBookIds(), listBookIds(), and getBookmarks() const member functions
2022-02-08 21:08:23 +01:00
Kelson
e1472b2a47
Merge pull request #783 from kiwix/fix_windows_contentmanager
Fix contentmanager/mainWindow initialisation on windows.
2022-02-08 08:46:04 +01:00
Matthieu Gautier
5b49480dd8 Set the fullscreen border after the windows is shown.
`windowHandle` return a valid value only if the widget has been shown.
So we must use it *after* it is shown, not at the end of its construction.

This subtle change also avoid a early return in the MainWindow constructor
and so, we correctly configure the mainWindow on Windows.
The last configuration is setting the content manager of the content manager
side. If this is skip, kiwix-desktop crash as soon as we click on "All files"
as we use a uninitialized pointer.
2022-02-07 17:09:24 +01:00
translatewiki.net
09db2a7a63
Localisation updates from https://translatewiki.net. (#778) 2022-02-03 15:41:25 +01:00
Kelson
88fa528d5b
Merge pull request #773 from xvitaly/fix-svg
Fixed SVG icon installation
2022-02-03 09:56:03 +01:00
Vitaly Zaitsev
e9855d7aeb
Fixed SVG icon installation.
Signed-off-by: Vitaly Zaitsev <vitaly@easycoding.org>
2022-02-02 18:47:40 +01:00
Kelson
1c70f375de
Merge pull request #779 from kiwix/legoktm-patch-1
PPA: Remove Ubuntu Hirsute, EOL
2022-02-01 08:28:48 +01:00
Kunal Mehta
c6b9acc87e
PPA: Remove Ubuntu Hirsute, EOL 2022-01-31 23:14:36 -08:00
Kelson
fe01853f3f
Merge pull request #751 from kiwix/540-part2-dont-emit-tabbar-signal-from-zimview
Part 2 to fix #540: don't emit tabbar signal from zimview
2022-01-31 09:07:53 +01:00
Alexander Sashnov
921615c970 Localize MainWindow inner-children connections
Move 'connect()' call from KiwixApp to MainWindow
because MainWindow should be responsible for connecting
its children between each other.
2022-01-29 02:50:02 +07:00
Alexander Sashnov
fd90eb8fe1 Drop 'KiwixApp::currentTitleChanged()' signal
When TabBar emits currentTitleChanged(), its only affects
other children of MainWindow: TopWidget and SearchBar.

So it makes the code more manageble if this knowledge
is local to MainWindow only.
2022-01-29 02:50:02 +07:00
Alexander Sashnov
60571e685d Drop extra '#include' 2022-01-29 02:49:56 +07:00