Veloman Yunkan
ec89f87d55
Cleaner download control button drawing primitives
2024-05-10 17:30:21 +04:00
Veloman Yunkan
553568ddc8
Renamed a variable
2024-05-10 17:30:21 +04:00
Kelson
18456eb9c4
Merge pull request #1098 from kiwix/united_states_of_books
...
Declaration of USB (Unified States of Books)
2024-05-09 15:28:41 +02:00
Veloman Yunkan
0ecb142ca6
Rewrote handling of last column clicks using book states
2024-05-09 15:16:30 +02:00
Veloman Yunkan
b6fbfb6104
Rewrote last column display using book states
2024-05-09 15:16:30 +02:00
Veloman Yunkan
7761c6f7b3
Context menu takes error states into account
2024-05-09 15:16:30 +02:00
Veloman Yunkan
d35fc1ff06
Rewrote context menu setup using book states
2024-05-09 15:16:30 +02:00
Veloman Yunkan
7bef510731
Enter ContentManager::BookState
2024-05-09 15:16:30 +02:00
Veloman Yunkan
b7fa28b811
Better nesting & indentation
2024-05-09 15:16:30 +02:00
Veloman Yunkan
9a754715f7
In some situations, short is better than long
2024-05-09 15:16:30 +02:00
Kelson
851ccc59c0
Merge pull request #1104 from ShaopengLin/Bugfix-Qt6-QVariant-TypeId
...
BugFix: Compilation Failure for Qt6 Due to Deprecated Members
2024-05-07 18:10:42 +02:00
ShaopengLin
086ba67b93
Fixed compilation failure in Qt6
...
Replaced deprecated member type() and QVariant::Type to compatible members in both Qt5&6
2024-05-07 11:47:47 -04:00
Veloman Yunkan
904dbb40bf
Merge pull request #1097 from kiwix/Route_de_Lausanne_107_Bourg-en-Lavaux
...
Fixed thumbnail display for books being downloaded
2024-05-04 01:02:59 +04:00
Veloman Yunkan
e12715e6c4
Fixed thumbnail display for books being downloaded
2024-05-02 11:34:42 +02:00
Veloman Yunkan
423f3e8d02
Trivial nano-cleanup
2024-05-02 11:21:09 +02:00
Veloman Yunkan
f70d0b3ccd
Download id is accessed directly via kiwix::Book
...
... whereupon `ContentManager::getBookInfos()` no longer needs to
support the `downloadId` key.
2024-05-02 11:20:23 +02:00
Matthieu Gautier
49858fffc6
Merge pull request #1096 from kiwix/Library_getArchive_doesnt_return_null
2024-05-01 18:36:17 +02:00
Veloman Yunkan
0a42126eff
Removed a check for a hence unachieavable situation
...
Now that `Library::getArchive()` never returns a null pointer the check
that was added a few commits ago as a fix for a particular manifestation
of a general problem is no longer needed.
2024-04-29 15:51:17 +02:00
Veloman Yunkan
2f9700db6b
Library::getArchive() returns non-null or throws
2024-04-29 15:35:38 +02:00
Kelson
073dd06937
Merge pull request #1092 from kiwix/download_dir_checks
...
Detection and reporting of issues with the download directory
2024-04-19 18:12:41 +02:00
Veloman Yunkan
616e2a730f
Reporting of issues with the download directory
...
Before this change a non-existent download directory would result in
"The system doesn't have enough storage available" error. Trying to save
files to non-writable directory resulted in the download seemingly being
stuck (but this is just a special case of not properly handling the download
error status returned by Aria).
2024-04-18 20:52:16 +02:00
Veloman Yunkan
3eeea9e9a0
ContentManagerError exceptions are let through
2024-04-18 20:52:16 +02:00
Veloman Yunkan
ab27a1a9a2
Prevent crashes due to stale bookmarks
...
`kiwix::Library::getArchiveById()` returns a `nullptr` when it turns out
that the ZIM file doesn't exist. That function was added in PR #536 and was
never documented, but that is no justification for us to let the
application crash.
2024-04-18 20:52:16 +02:00
Kelson
07171bad92
Merge pull request #1090 from vinurk/fix/reading-list-shortcut
...
Changes toggle reading list shortcut to Ctrl+B
2024-04-18 17:27:44 +02:00
vinurk
0e5ea8b945
changed shortcut
2024-04-17 01:11:47 +05:30
Matthieu Gautier
2a6fd5f2fa
Merge pull request #1085 from kiwix/no_werror
2024-04-15 14:07:41 +02:00
Matthieu Gautier
d896c17096
Remove -Werror on Windozs.
...
`-Werror` make compilation fails on Windows.
2024-04-15 10:22:41 +02:00
Kelson
cce7de8820
Merge pull request #1086 from kiwix/handling_of_corrupted_xapian_db
...
Handling of corrupted Xapian DB during search
2024-04-12 16:57:20 +02:00
Veloman Yunkan
79bf30577f
Handling of corrupted Xapian DB during search
2024-04-12 16:55:40 +02:00
Kelson
20f32d03b5
Merge pull request #1061 from ShaopengLin/Issue#967-fix-search-bar-shortcut
...
Fix #967 : Search Bar Key Board Short Cut Performs the same as Mouse Click
2024-04-12 12:59:07 +02:00
ShaopengLin
366ab1d173
SearchBar shortcuts work now
...
Refactored shortcut to search bar and removed redundant code. Fix #967
2024-04-12 12:48:41 +02:00
Kelson
0b18cc6a32
Merge pull request #1081 from kiwix/kiwix_Downloader_close_may_throw
...
Handling of exceptions from kiwix::Downloader::close()
2024-04-12 12:48:18 +02:00
Veloman Yunkan
11cdeb9faa
Handle exceptions from kiwix::Downloader::close()
2024-04-12 09:31:59 +02:00
Kelson
ccccc80dfe
Merge pull request #1080 from kiwix/fullscreen_keysequence_fix
...
Fixed the fullscreen keyboard shortcut
2024-04-12 09:27:40 +02:00
Veloman Yunkan
1ccfcadf2b
Fixed the fullscreen keyboard shortcut
...
`Qt::Key_F11` and `QKeySequence::FullScreen` are of different enum types
(`Qt::Key` and `QKeySequence::StandardKey`, respectively) with
overlapping value ranges. Using a standard integral type (int, unsigned,
long, etc) as a common type for them results in the type information
being lost and an ensuing impossibility to take advantage of overloaded
constructors of `QKeySequence`. The simple fix is to use `QKeySequence`
as the common type of the conditional expression.
2024-04-12 09:26:47 +02:00
Kelson
b3b09c47ef
Merge pull request #1064 from sgourdas/feature/fullscreen_scrollbar
...
Fixed dragging of scrollbar in fullscreen
2024-04-12 09:23:14 +02:00
sgourdas
9639a3f777
Always return false on MainWindow eventFilter
2024-04-12 09:15:22 +02:00
Kelson
2f364ebd89
Merge pull request #1077 from sgourdas/feature/order_headers
...
Properly order headers
2024-04-12 09:14:09 +02:00
sgourdas
c8f731d015
Properly order header includes
2024-04-12 09:07:40 +02:00
Matthieu Gautier
ae2f4d6cde
Merge pull request #1082 from kiwix/fix_ci_deps
2024-04-11 17:44:09 +02:00
Matthieu Gautier
611fc67e28
Use new name for target_platform in CI
2024-04-11 17:38:24 +02:00
Veloman Yunkan
7f2a0491c6
Merge pull request #1075 from vinurk/fix/reset-view-findinpage
...
Don't reset the webview on exiting search-in-page
2024-04-08 18:48:29 +04:00
vinurk
aa884b3b3a
fixed view reset on findinpage close
2024-04-08 14:57:24 +02:00
Kelson
4c5128415a
Merge pull request #1066 from sgourdas/feature/bookmark_qol
...
Changing boomark icon to star and adding tooltip
2024-04-07 21:10:05 +02:00
sgourdas
e61ca4b8b4
Fixed bookmark icon size and reversed display
2024-04-07 20:35:06 +02:00
sgourdas
7d94c06810
Changed the icon of bookmarking action to a star
...
Also:
- Added tooltip for add/remove on reading list
2024-04-07 20:35:06 +02:00
Kelson
7e2012d00d
Merge pull request #1071 from sgourdas/feature/nostrip
...
Added nostrip to CONFIG to avoid illegal binary strips on WSL
2024-04-07 20:34:41 +02:00
sgourdas
54a3f2596c
Use CONFIG nostrip on WSL due to illegal strips
2024-04-07 20:23:58 +02:00
Kelson
9ea2199f31
Merge pull request #1056 from kiwix/translatewiki
...
Localisation updates from https://translatewiki.net .
2024-04-06 10:21:53 +02:00
translatewiki.net
d3afe4a2f0
Localisation updates from https://translatewiki.net .
2024-04-06 10:21:18 +02:00
