nullworks/cathook
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

votelogger.cpp: small refactor and fix

Browse Source 
Use std::snprintf in place where it is supposed to be
Comment ';' character usage
Fix always voting yes to kick despite vote_kicky being false
This commit is contained in:
Unnamed 2019-01-12 12:02:16 +00:00 committed by TotallyNotElite
parent 051fe3211f
commit be2004fab6
1 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/votelogger.cpp
View File

@ -53,15 +53,25 @@ void dispatchUserMessage(bf_read &buffer, int type)
auto &pl = playerlist::AccessData(info.friendsID);
if (*vote_kickn && pl.state != playerlist::k_EState::RAGE && pl.state != playerlist::k_EState::DEFAULT)
g_IEngine->ClientCmd_Unrestricted("vote option2");
else if (*vote_kicky && pl.state == playerlist::k_EState::RAGE || pl.state == playerlist::k_EState::DEFAULT)
else if (*vote_kicky && (pl.state == playerlist::k_EState::RAGE || pl.state == playerlist::k_EState::DEFAULT))
g_IEngine->ClientCmd_Unrestricted("vote option1");
}
if (*party_say && g_IEngine->GetPlayerInfo(caller, &info2))
{
char formated_string[512];
// because tf2 is stupid and doesn't have escape characters,
// use the greek question marks instead. big brain.
// Clang-format why, TODO: Don't use format func
g_IEngine->ExecuteClientCmd(format("say_party [CAT] votekick called: ", boost::replace_all_copy((std::string) info2.name, ";", ";"), " => ", boost::replace_all_copy((std::string) info.name, ";", ";"), " (", reason, ")").c_str());
std::string kicked_name(info.name), caller_name(info2.name);
/* ';' (0x3B) regular replaced with unicode analog ';' (0xCD 0xBE)
* to prevent exploits (by crafting name such that it executes command)
* and output message properly
* TO DO: Saner way to accomplish same */
ReplaceString(kicked_name, ";", ";");
ReplaceString(caller_name, ";", ";");
std::snprintf(formated_string, sizeof(formated_string),
"say_party [CAT] votekick called: %s => %s (%s)",
caller_name.c_str(), kicked_name.c_str(), reason);
g_IEngine->ExecuteClientCmd(formated_string);
}
logging::Info("Vote called to kick %s [U:1:%u] for %s", name, steamID, reason);
break;