8647 Commits

Author SHA1 Message Date
MohitMaliFtechiz
2e9417c3ac Fixed: ZimManageViewModelTest was failing on CI. 2025-07-02 14:11:03 +05:30
MohitMaliFtechiz
e0849fa183 Fixed: Library language list is now retrieved dynamically from libkiwix.
* Previously, we used `Locale.getISOLanguages()` to display the language list. However, this did not include all the languages in which books are available. Now, we use the `OPDS` stream via libkiwix to fetch online books, and utilize a method in libkiwix that provides the list of available book languages. This dynamically retrieved list is now shown in the `LanguageFragment`, allowing users to select a language and download books accordingly.
* The `LanguageFragment` previously relied on `ObjectBox` for storing and managing selected languages. This has now been migrated to use `Room` database instead.
* A migration strategy has been added to move previously selected languages from ObjectBox to Room.
* Corresponding test cases for migration have been added, and existing tests have been refactored to reflect these changes.
* Since we now rely on `libkiwix` to retrieve the language list, the `ZimManageViewModelTest` initially failed due to native code dependencies (JNI) not loading in unit test environments. To address this, we refactored the code and introduced a `JNIModule` class in the app module (where `OnlineLibraryManager` resides). We now inject the `Library` object, allowing us to pass a mocked instance to `ZimManageViewModel` for proper unit testing.
2025-07-02 01:02:33 +05:30
Kelson
85f11a71cc
Merge pull request #4335 from kiwix/translatewiki
Localisation updates from https://translatewiki.net.
2025-07-01 10:13:16 +02:00
translatewiki.net
eb125b3342 Localisation updates from https://translatewiki.net. 2025-07-01 10:13:06 +02:00
Kelson
11a2f90b6d
Merge pull request #4337 from jackq97/#4332_migrate_donation_layout_into_compose
#4332 migrate donation layout into compose
2025-06-29 11:18:21 +02:00
MohitMaliFtechiz
1e9e634fca Added DonationDialogTest UI test cases to thoroughly verify the functionality using Compose UI.
* Minor improvements to dark mode styling for the donation layout buttons.
2025-06-28 20:11:13 +05:30
MohitMaliFtechiz
bea28a16a3 Fixed: The donation layout was not respecting the dark theme.
* Fixed: The alignment of donation layout.
* Improved the `DonationLayout` code for better readability and maintainability.
2025-06-28 01:08:25 +05:30
MohitMaliFtechiz
fb59174d6e Migrated the DonationLayout to Jetpack Compose.
* Implemented the `DonationLayout` using Compose UI.
* Refactored the `ReaderScreen` to integrate the new Compose-based layout.
* Added a maximum width constraint to the donation layout to prevent it from appearing too wide in landscape mode or on tablets.
* Removed unused code from the project.
2025-06-28 00:30:07 +05:30
Kelson
17936cd0b0
Merge pull request #4336 from kiwix/FIxes#4248
Migrated the `Reader` screen to jetpack compose.
2025-06-26 22:09:02 +02:00
MohitMaliFtechiz
eca3c355b2 Fixed: SearchFragmentTestForCustomApp was failing.
* Fixed: The appearance of TTS control buttons.
2025-06-26 18:09:26 +05:30
MohitMaliFtechiz
a6eb00f6b9 Refactored the remaining UI test cases. 2025-06-26 17:21:59 +05:30
MohitMaliFtechiz
a51615e249 Fixed: An extra space appeared at the bottom when navigating to a ZIM page with greater height and then returning to the previous page.
* Removed unnecessary code and files from the project.
* Refactored several UI test cases to align with the Compose UI.
* Fixed: Some lint issues.
2025-06-26 00:52:06 +05:30
MohitMaliFtechiz
db22e245b7 Fixed: WebView was not occupying full height when the BottomAppBar was hidden.
* Moved the scrolling logic of the WebView into the Compose UI, as custom scroll handling in the WebView was causing issues.
* Removed ToolbarScrollingKiwixWebView since it's no longer needed—scrolling is now managed entirely within Compose.
* Added animations for opening and closing the tab switcher view.
2025-06-25 01:50:22 +05:30
MohitMaliFtechiz
3ebb37d5cc Refactored the TOC button functionality to handle cases where custom apps are configured to disable it.
* Fixed: Missing bottom margin in custom apps.
* Fixed: Reader's bottom app bar not appearing after closing or selecting a tab.
* Fixed: Menu not showing in the toolbar when the application is freshly launched in custom apps.
* Refactored the scroll behavior of the toolbar and bottom app bar to sync with WebView scrolling in the Compose UI.
2025-06-24 01:23:18 +05:30
MohitMaliFtechiz
2608694442 Fixed: Clicking on "Plus button" in tab switcher crashes the application.
* Refactored the "FullScreen Video" functionality according to compose UI.
* Refactored the functionality where custom app is configured to show search placeholder in toolbar, and created the search placeholder in compose.
* Refactored the functionality where custom app is configured to show app icon in place of humbuger icon.
2025-06-21 00:46:15 +05:30
MohitMaliFtechiz
234e9169f6 Fixed: Tabs were being automatically restored after closing them, navigating away from the reader screen, and then returning.
* Removed unused code from the reader screen.
* Refactored fullscreen mode functionality to align with Compose UI.
* Improved the `CloseAllTabs` button styling to match the app theme.
* Refactored the "Back to Top" button functionality using Compose, and enhanced its UI.
* Fixed: `Long-press` on bottom app bar buttons was not working due to `IconButton` consuming the touch event.
* Removed the unused `AnimationUtils` file.
* Fixed: Navigation history (forward and backward) was not being displayed.
2025-06-19 23:58:38 +05:30
MohitMaliFtechiz
b694ae3170 Refactored all tab-related functionalities.
* Improved the tabs UI to align with our XML-based layout. Added a border to the selected tab for better visual feedback, making it easier for users to identify the active tab.
* Added animation to smoothly scroll to the selected tab when the tab switcher is opened.
* Fixed a crash scenario when "Close All Tabs" was triggered.
* Fixed a crash that occurred when launching the app for the first time.
* Fixed an issue where the tab menu item was still visible even after all tabs were closed.
2025-06-19 02:55:45 +05:30
MohitMaliFtechiz
f654a64b7e Refactored all functionalities of the Reader's menu: showing or hiding menu items based on business logic, updating the tab item count, and more.
* Improved the KiwixAppBar to support custom views in menu items — enabling custom UI like the tab switcher.
* Fixed: TTS controls were not displaying correctly on the UI.
* Refactored the TTS functionality to align with the Compose UI architecture.
* Fixed: Some lint issues and improve the code quality.
2025-06-18 02:23:32 +05:30
MohitMaliFtechiz
5c879484a6 Fixed: WebView was not loading content properly in Compose.
* Refactored KiwixAppBar to support a string title instead of a string resource ID, allowing dynamic titles like ZIM file names.
* Fixed: ZIM file title was not appearing correctly in the toolbar.
* Refactored all snackbar-related functionalities on the reader screen.
* Updated KiwixAppBar to support an overflow menu.
* Introduced ReaderMenuState to manage menu item state dynamically for improved maintainability.
2025-06-17 20:59:10 +05:30
MohitMaliFtechiz
6ea560407d Created the TabsView to display tabs on the Reader screen.
* Improved the UI of the `Reader screen` to display the tabs view properly.
* Refactored functionalities in `CoreReaderFragment`, including bottom toolbar interactions, runtime UI updates, and handling of the "No Book Open" button, etc.
2025-06-17 20:59:10 +05:30
MohitMaliFtechiz
39baa985fb Migrated the Reader screen to jetpack compose.
* Created the `ReaderScreen` for compose UI.
* Created the `ReaderScreenState` to manage the state of UI.
2025-06-17 20:59:10 +05:30
Kelson
11d1c161c6
Merge pull request #4334 from kiwix/FIxes#3108
Migrated on-disk BookStores/ZimStores from ObjectBox to libkiwix.
2025-06-13 18:56:35 +02:00
MohitMaliFtechiz
e24d214553 Fixed: ZimManageViewModelTest which was failing on CI. 2025-06-12 14:53:37 +05:30
MohitMaliFtechiz
c2d35e17d4 Added migration test cases for migrating the objectBox data to libkiwix.
* Fixed: `ImportBookmarkTest` which was failing on CI.
* Refactored UI and unit test cases according to the new codebase.
* Fixed: Selecting a ZIM file would select all ZIM files displayed on the Local Library screen.
* Fixed: `network result & language db results activate a combined network + db result`, `library marks files over 4GB as can't download if file system state says to` and `books found on filesystem are filtered by books already in db`, which sometimes fails on the CI.
2025-06-12 00:18:50 +05:30
MohitMaliFtechiz
42da475867 Refactored all functionalities to use LibkiwixBookOnDisk instead of NewBookDao.
* Fixed: Saved books in the library were not appearing on the Local Library screen.
* Fixed: Opening a ZIM file via the download notification was not working.
* Fixed: Selecting a ZIM file would select all ZIM files displayed on the Local Library screen.
* Improved: Migration logic now properly migrates books that were stored in the file system before introducing `ZimReaderSource`.
2025-06-11 00:53:35 +05:30
MohitMaliFtechiz
8370f72d35 Migrated on-disk BookStores/ZimStores from ObjectBox to libkiwix. 2025-06-10 00:28:45 +05:30
Kelson
5b64e21127
Merge pull request #4327 from kiwix/translatewiki
Localisation updates from https://translatewiki.net.
2025-06-07 20:35:58 +02:00
translatewiki.net
f2942d71b9 Localisation updates from https://translatewiki.net. 2025-06-07 20:35:34 +02:00
Kelson
18e3b3d9b6
Merge pull request #4333 from kiwix/Fixes#4298
Introduced support of OPDS catalog.
2025-06-07 13:29:33 +02:00
MohitMaliFtechiz
40edd03396 Fixed: Bookmarks were not showing for newly added books from the OPDS stream.
* Removed books from `library.xml` if they no longer have any associated bookmarks, as keeping them is unnecessary and wastes resources and memory, while also increasing the time needed to load the library from storage.
* Fixed: The downloading online library progress was showing incorrect.
* Refactored the all unit test cases according to the new changes.
2025-06-07 00:02:09 +05:30
MohitMaliFtechiz
ebbe1b9889 Fixed: Downloading was not working.
* Fixed: `Online Books` were showing incorrect book sizes. The OPDS stream now provides sizes in bytes instead of kilobytes, so the code has been updated accordingly.
* Added the `io.coil-kt.coil3:coil-compose` library to load favicons for online books, as OPDS now returns favicon URLs instead of Base64-encoded strings.
* Since favicons are no longer provided in Base64 format when downloading ZIM files, we now extract the favicon from the Archive using libkiwix after the download completes. This allows us to display it locally on various screens such as the library, Wi-Fi hotspot, notes, history, and more.
* Cached the `LibkiwixBook` instance to avoid recreating it multiple times when adding or removing bookmarks.
2025-06-05 23:49:02 +05:30
MohitMaliFtechiz
7a10528d19 Added the com.squareup.retrofit2:converter-scalars converter to Retrofit to parse OPDS network responses.
* Created `LibkiwixBook` to wrap the `Book` class from `libkiwix`, allowing us to set custom values from the database and manage books received from the `OPDS` stream. This wrapper is necessary because the original Book class does not provide setters. We'll use `LibkiwixBook` throughout the codebase.
* Refactored the codebase to replace `LibraryNetworkEntity.Book` with `LibkiwixBook`.
2025-06-04 22:16:09 +05:30
MohitMaliFtechiz
20722fe15b Introduced support of OPDS catalog. * Created the OnlineLibraryManager class to manage the OPDS stream with libkiwix. * Refactored the ZimManageViewModel, and KiwixService code according to OPDS catalog. 2025-06-03 18:42:51 +05:30
Kelson
ccffb07ae4
Merge pull request #4331 from kiwix/Fixes#4244
Migrated the `Settings` screen to Jetpack Compose.
2025-06-02 15:14:33 +02:00
MohitMaliFtechiz
81b4a0be34 Fixed: Cancel button in language dialog was hidden due to oversized content. 2025-06-02 17:08:07 +05:30
MohitMaliFtechiz
5ab5529acf Refactored all UI test cases to align with the new settings Compose UI. 2025-06-02 16:50:08 +05:30
MohitMaliFtechiz
ba476058fe Fixed: The Text Zoom slider did not correctly display the previously set position after restarting the application.
* Removed the BaseDelegateAdapter and its subclasses, as RecyclerView is no longer used in the codebase.
* Fixed: CustomApps was crashing when opening the settings screen.
* Fixed: StorageList was not appearing on the settings screen.
* Fixed: Dark Mode and Language dialogs to match the theme design.
* Created KiwixBasicDialogFrame, a reusable Compose UI component to standardize the design of alert dialogs.
* Removed unused code from the project.
2025-05-30 17:55:02 +05:30
MohitMaliFtechiz
164e38b113 Refactored the remaining functionality to use Jetpack Compose UI.
* Improved the design of the `Settings` screen to match the previous XML layout.
* Updated the ViewModel to handle user interactions following the MVVM pattern.
* Introduced `SettingScreenState` to manage the state of the settings screen.
* Removed `KiwixPrefsFragment`, `CustomPrefsFragment`, and `CorePrefsFragment` as they are no longer needed.
* Cleaned up unused code from the project.
2025-05-29 19:04:40 +05:30
MohitMaliFtechiz
5aac7e4815 Migrated the Settings screen to Jetpack Compose.
* Created the `SettingsScreen` using Jetpack Compose UI components.
* Implemented `SettingsViewModel` to manage and update preferences reactively, supporting the Compose architecture.
* Refactored existing functionality to align with the Compose-based UI.
2025-05-29 19:04:40 +05:30
Kelson
5767f74fdb
Merge pull request #4325 from Abhi-Bohora/refacConnBroadRecvr
Refactored `RxJava` to `coroutines` in `ConnectivityBroadcastReceiver`.
2025-05-28 09:02:49 +02:00
MohitMaliFtechiz
6cae44821e Refactored RxJava to coroutines in ConnectivityBroadcastReceiver.
* Simplified the `combineToLanguageList` method and removed warnings.
* Refactored `ZimManageViewModelTest` to align with the changes.
* Removed unused `RxJava` code from the project.
* Removed all `RxJava` dependencies from the project.
* Updated the `README` file to reflect that `RxJava` is no longer used.
* Updated `credit.html` accordingly, similar to the `README`.
2025-05-27 17:48:28 +05:30
Kelson
ad62661e67
Merge pull request #4329 from kiwix/Fixes#4246
Migrated `SearchFragment` to jetpack compose.
2025-05-27 10:45:42 +02:00
MohitMaliFtechiz
de807f2a51 Fixed: SearchFragmentTestForCustomApp which sometimes failing on API level 33 and above. 2025-05-27 12:33:51 +05:30
MohitMaliFtechiz
3ee0977534 Removed debug logs. 2025-05-26 22:41:41 +05:30
MohitMaliFtechiz
0099f4dcf4 Fixed: CodeFactor issue. 2025-05-26 22:37:37 +05:30
MohitMaliFtechiz
31cc84664c Improved the KiwixSearchView to handle the keyboard onDone button press. Now, when the user presses the Done button on the keyboard, it triggers the search and opens the first matching item, if available.
* Fixed: The `FIND_IN_PAGE` button was appearing when the search was opened from `FromTabView`.
* Fixed: The `FIND_IN_PAGE` button was not displaying properly (only half was visible).
* Improved: The `NavigationIcon` to better support test cases.
* Fixed: `VoiceSearch` was not working when launched from the `SearchWidget`.
* Refactored: `SearchFragmentTest` and `SearchFragmentTestForCustomApp` to align with the Compose UI.
* Removed: Additional unused code from the project.
2025-05-26 22:31:25 +05:30
MohitMaliFtechiz
a3b1b95181 Migrated SearchFragment to jetpack compose.
* Improved the `KiwixAppBar` to show the textButton in actionMenu. Since we need to show the `FIND_IN_PAGE` textView button in actionMenu.
* Created the `SearchScreen` and migrated the all UI to compose from XML.
* Refactored the functionalities of `SearchFragment` according to compose UI.
* Removed the unused code from project.
2025-05-26 14:07:33 +05:30
Kelson
10494cccf9
Merge pull request #4328 from kiwix/Fixes#4302
Refactored `RxJava` to `coroutines` in `OnlineLibrary`.
2025-05-23 17:01:19 +02:00
MohitMaliFtechiz
e7b1c94f3b Improved the display of the "Downloading online library progress" message — previously, it was sometimes not shown, and only the progress bar at the top was visible.
* Updated the logic to hide the top progress bar when updating the library items while applying filters.
* Refactored all unit test cases to properly support coroutines.
2025-05-22 23:55:13 +05:30
MohitMaliFtechiz
989b22f563 Fixed: Network violation issue while downloading the online library.
* Fixed: Download progress of the online library was not displayed when navigating away from the fragment and returning while the download was still in progress.
* Fixed: Both the SwipeRefreshIndicator and the progress bar were shown simultaneously during the initial download of the online library.
* Improved: The logic for hiding the SwipeRefreshIndicator. It now automatically hides when the progress bar (with visible progress) is displayed.
* Improved: Handling of library re-downloads upon network state changes.
* Fixed: The progressBar was showing when we searching for books.
* Fixed: Compilation errors in unit test cases.
2025-05-21 18:44:25 +05:30