11937 Commits

Author SHA1 Message Date
SomeTroglodyte
480fd1fb29
That was an invalid use of "property access syntax" for setXX/getXX pairs (#13582) 2025-07-06 00:07:02 +03:00
Rob Loach
abf63dbc91
Add unit state for tile improvement conditionals (#13574)
* Use stateForConditionals through build improvement checks

* Fix tests
2025-07-06 00:06:43 +03:00
SomeTroglodyte
4f9ca56781
Remove Mod Checks from running during startup (#13528)
* Do not run RulesetValidator on every installed Mod on every RulesetCache.loadRulesets

* Remove altogether...

* Oops, how embarrassing, me leaving in obsolete imports
2025-07-06 00:06:31 +03:00
yairm210
bfc8a54d0e Added "UI Scale" translation item for #13518 2025-07-03 15:19:34 +03:00
yairm210
d6d8f3c930 4.17.2 4.17.2 2025-07-03 12:37:31 +03:00
Yair Morgenstern
9665611c2f
Version rollout (#13569)
* Bump version and create initial changelog entry

* Updated German.properties (#13556)

* Add files via upload

* Update German.properties

* Update German.properties

Changed declared requirements

* Update French.properties (#13555)

* Update Catalan.properties (#13552)

* Update Korean.properties (#13551)

* Edit Korean.properties

* Update Korean.properties

* Update Korean.properties

* Update Korean.properties

* Update Persian_(Pinglish-UN).properties (#13549)

- Added some translations
- Fixed some translations

* Update Indonesian.properties (#13545)

---------

Co-authored-by: yairm210 <yairm210@users.noreply.github.com>
Co-authored-by: Felix Kröhnert <70710128+cy-elec@users.noreply.github.com>
Co-authored-by: Ouaz <Ouaz@users.noreply.github.com>
Co-authored-by: Joan Josep <juanjo.ng.83@gmail.com>
Co-authored-by: Charmtese <saud2410@naver.com>
Co-authored-by: Ilia <81512402+ilia-abbasi@users.noreply.github.com>
Co-authored-by: X2003 <158255876+Xenia2003@users.noreply.github.com>
2025-07-03 11:42:55 +03:00
SomeTroglodyte
02d3c110aa
Move parsing of localized numbers to UncivTextField (#13550)
* Move parsing of localized numbers to UncivTextField

* Docs!
2025-07-03 11:02:36 +03:00
SomeTroglodyte
0846b6d486
Better Validation of Nation colors (#13568)
* Fix json arrays that aren't [r,g,b] causing Ruleset load to throw

* Fix checkNation forgetting to call its super

* Ruleset-Validate array content of Nation colors
2025-07-03 11:02:24 +03:00
Rob Loach
212a772190
When capturing settlers, fix finding the Worker units with conditionals (#13565)
* Fix capturing Settlers when Workers have conditional build improvements

* The ignore conditional for build improvement should apply to OneTimeFreeUnitsRuins too
2025-07-03 11:02:16 +03:00
yairm210
4f44c7236c Resolves #13540 - Fix ancient ruins not spawning as much as they should 2025-07-03 11:01:53 +03:00
yairm210
ede5ebdf75 Maybe fix Android dev console - will require testing 2025-07-03 11:00:02 +03:00
yairm210
9319d16002 Fixed Happiness being found as a global stat 2025-07-03 11:00:02 +03:00
Rob Loach
11b53f6cdc
Add ability to remove policies with ModOptions (#13548)
* Add ability to remove policies with ModOptions

* Remove policies from the branches too

* Clean docs
2025-07-03 10:59:08 +03:00
SomeTroglodyte
834239774a
Avoid List.removeFirst() not being available on Android API 21..34 levels (#13567) 2025-07-03 10:24:01 +03:00
yairm210
06d6a1bfe1 Resolves #13557 - trigger conditionals are a superset not global uniques 2025-07-02 21:49:40 +03:00
SomeTroglodyte
911584dc49
Minor Unique documentation improvements (#13559)
* UniqueDocsWriter outputs UniqueFlag HiddenToUsers and NoConditionals

* UniqueDocsWriter: Make other hints get their own line after mkdocs is done with them

* Be honest about OneTimeGlobalAlert
2025-07-02 11:07:00 +03:00
yairm210
368f6d14c4 "Unowned" capitalized for consistency, whoops 2025-07-01 16:58:51 +03:00
yairm210
7f29dab09f Added "unowned" tileFilter for #13554 2025-07-01 16:46:44 +03:00
SomeTroglodyte
10a4be2214
Fix doc writer escaping (#13546)
* Fix UniqueDocsWriter escaping

* Delete orphan file
2025-06-30 07:58:53 +03:00
yairm210
79a92a10ea 4.17.1 4.17.1 2025-06-29 18:11:09 +03:00
Yair Morgenstern
c1d1024e32
Version rollout (#13544)
* Bump version and create initial changelog entry

* Update Ukrainian translation (#13538)

* translation: update Simplified Chinese (#13536)

Co-authored-by: chr56 <_>

* Update French.properties (#13533)

* update croatian translation (#13532)

* Update Italian.properties (#13531)

* Update Ukrainian.properties (#13530)

Changing a non-Ukrainian word to a Ukrainian one.

* Update Indonesian.properties (#13526)

---------

Co-authored-by: yairm210 <yairm210@users.noreply.github.com>
Co-authored-by: Kostiantyn Ko <mormat.iam@gmail.com>
Co-authored-by: chr_56 <30681738+chr56@users.noreply.github.com>
Co-authored-by: Ouaz <Ouaz@users.noreply.github.com>
Co-authored-by: metablaster <44481081+metablaster@users.noreply.github.com>
Co-authored-by: Giuseppe D'Addio <41149920+Smashfanful@users.noreply.github.com>
Co-authored-by: smrtkcpm <findingdory1912@gmail.com>
Co-authored-by: X2003 <158255876+Xenia2003@users.noreply.github.com>
2025-06-29 18:07:01 +03:00
SomeTroglodyte
9ce15a1679
Fix ModCheckTab to match the intention of the last update (#13527) 2025-06-29 18:04:10 +03:00
SomeTroglodyte
6d3ea5260b
Fix console tile find for quoted input or filters requiring correct uppercase, expand notification (#13542) 2025-06-29 18:02:27 +03:00
Tice with a J
28f8777447
Make Machu Picchu and Neuschwanstein need a non-Natural Wonder mountain (#13539)
* Update Buildings.json to make Wonders need non-Natural Wonder mountains

* Make Machu Picchu need a non-Natural Wonder mountain
2025-06-29 18:02:19 +03:00
SomeTroglodyte
be354785c4
Fix mod check not offering to auto-update Uniques for extension mods (#13535)
* Reenable Unique auto-update by fixing the validation on the replacement

* Make mod name search in Mod Checker find those disabled placeholders too
2025-06-29 18:02:12 +03:00
SomeTroglodyte
dbf28c675a
Speed and Difficulty uniques treated as part of GlobalUniques (#13513)
* Linting

* Make Difficulty a full RulesetObject

* Make Speed and Difficulty uniques work as if part of GlobalUniques

* Now that they have an effect, they should be visible in Civilopedia

* Autogenerated docs

* Fix lost import

* Fix unit test encapsulation
2025-06-29 18:02:01 +03:00
Rob Loach
d0b43599d9
Fix mod names with dashes in them (#13523)
* Fix mod names with three dashes

* Fix display of mods with three dashes in the name

* Remove unneeded Ruleset call
2025-06-29 18:00:47 +03:00
yairm210
7adf726580 Fix linting 2025-06-29 18:00:00 +03:00
yairm210
7b106eeb7b chore: ArrayList.getOrPut is now an extension 2025-06-29 11:50:46 +03:00
yairm210
cad7bd70a0 Perf(cpu): Convert passThroughCache from a hashmap to an arraylist, using the zero-based index for tiles 2025-06-29 00:22:00 +03:00
yairm210
1ad113e363 doc: updates 2025-06-28 23:13:36 +03:00
yairm210
e8fd27bf34 Fixed dev console requiring scrolling on small UI settings 2025-06-28 23:13:04 +03:00
SomeTroglodyte
f3c8e2d009
UniqueDocsWriter escapes examples that include conditionals (#13525)
* Escape`<>` in docDescription rendering, and don't glue the "Applies to" to its end

* gitignore mkdocs output
2025-06-28 22:51:09 +03:00
SomeTroglodyte
15e09ceb1f
Improve wiki - Clarify "modName" parameter and check links (#13529)
* Correct all Warnings and Info's thrown by mkdocs

* Clarify modFilter documentation
2025-06-27 14:37:14 +03:00
yairm210
fe9423d9e7 4.17.0 4.17.0 2025-06-27 00:09:20 +03:00
Yair Morgenstern
bd60575584
Version rollout (#13524)
* Bump version and create initial changelog entry

* update galician translate gl_ES (#13520)

* Update Galician.properties

update translate

* Update Galician.properties

update translate

* Update Galician.properties

fix error in line 1124

* Update Galician.properties

fix in line 380

* Update Italian.properties (#13516)

* Update Brazilian_Portuguese.properties (#13515)

* Update Korean.properties (#13514)

* Update French.properties (#13511)

* Update Indonesian.properties (#13510)

* update croatian translation (#13508)

---------

Co-authored-by: yairm210 <yairm210@users.noreply.github.com>
Co-authored-by: ninjum <138787523+ninjum@users.noreply.github.com>
Co-authored-by: Giuseppe D'Addio <41149920+Smashfanful@users.noreply.github.com>
Co-authored-by: Vitor Gabriel <59321138+Ranbut@users.noreply.github.com>
Co-authored-by: Charmtese <saud2410@naver.com>
Co-authored-by: Ouaz <Ouaz@users.noreply.github.com>
Co-authored-by: X2003 <158255876+Xenia2003@users.noreply.github.com>
Co-authored-by: metablaster <44481081+metablaster@users.noreply.github.com>
2025-06-27 00:05:52 +03:00
yairm210
f6d859e0ec Resolved #13174 - AI considers tile damage when deciding on which tile to heal on 2025-06-27 00:04:43 +03:00
SomeTroglodyte
9f3f6ea0ca
Improve ModChecker UI (#13507)
* Minor linting

* Move error severity icon to where the color is, fixing "Orange-level bad" being a "positive" Checkmark

* Move 'open unique builder' to helper, fixing the premature expensive instantiation of another copy of the combined ruleset

* Move the per-mod UI code to helper function for readability

* Make background coroutine cancellable and use that

* Fix base out of sync between SelectBox and actual check after autoUpdateUniques

* Make changes to search while a check is running work properly

* Use LoadingImage instead of moving label to indicate in progress

* Skip mods that we know won't work with the current base selection

* Default base to check against: determined automatically

* Add lost check for changed search while a check is still running

* Cleaner Job Cleanup
2025-06-26 23:46:06 +03:00
SomeTroglodyte
2d3b6047f3
Allow mods with no global uniques, no ruins or no difficulties file (#13521)
* Allow mods with no GlobalUniques

* Allow mods omitting Difficulties to fall back to Vanilla

* Allow mods with no Ancient Ruins + Checks
2025-06-26 23:45:34 +03:00
EmperorPinguin
86d7324298
AI: update CreatesOneImprovement handling (#13497)
* Update

* Update Automation.kt

* Update Automation.kt

* Update Automation.kt

* Update Automation.kt
2025-06-26 23:45:06 +03:00
SomeTroglodyte
fce04aaddd
Under-the-hood improvements around Speed and Years (#13482)
* Mini-refactor: YearsPerTurn can be immutable, support destructuring

* Lint: Replace non-rendering unicode points with escapes

* Wiki: Describe `Speed.turns` better

* A unit test for turn-to-year conversion

* Faster turn-to-year math

* Readability changes
2025-06-26 23:44:54 +03:00
SomeTroglodyte
4ac0400c2e
Update wiki - fix oversights, clarify what is optional in base ruleset mods, new features (#13522)
* Modder wiki: Fix personalities breaking up rendering, open them up and lint

* Modder wiki: Fix incomplete table of contents (oops, the link for the later "Add a table" commit is in here)

* Modder wiki: Emphasize and explain more basic Json rules - @SpacedOutChicken's "but modders may copy examples verbatim without knowing quotes meant to be part of literals must be escaped"

* Modder wiki: Add a table documenting base ruleset fallbacks / what can be empty

* Modder wiki: Add documentation for PR #13513

* Modder wiki: Add or clarify fallbacks used for base ruleset Mods

* Clear up question marks - the template mod works with no objects of those types

* Remove duplicate Personalities paragraph

* Revert "Remove duplicate Personalities paragraph"

This reverts commit d785b546af1537a1e3add56a4ff83a9b178d404d.

* Revert more Personality changes, leaving only the file link

* Minor fixes
2025-06-26 23:43:38 +03:00
yairm210
89f6b6fe8b Fixed building maintenance unique 2025-06-26 23:41:10 +03:00
yairm210
5b5495397f 4.16.19 4.16.19 2025-06-23 23:23:47 +03:00
Yair Morgenstern
91bda736ff
Version rollout (#13506)
* Bump version and create initial changelog entry

* Update French.properties (#13505)

* Fixed wrongly translated line (#13502)

* Update Italian.properties (#13501)

* Update Ukrainian translation (#13499)

* Update Brazilian_Portuguese.properties (#13498)

* Update Indonesian.properties (#13487)

* update croatian translation (#13486)

---------

Co-authored-by: yairm210 <yairm210@users.noreply.github.com>
Co-authored-by: Ouaz <Ouaz@users.noreply.github.com>
Co-authored-by: Crsi <47722349+CrsiX@users.noreply.github.com>
Co-authored-by: Giuseppe D'Addio <41149920+Smashfanful@users.noreply.github.com>
Co-authored-by: Kostiantyn Ko <mormat.iam@gmail.com>
Co-authored-by: Vitor Gabriel <59321138+Ranbut@users.noreply.github.com>
Co-authored-by: X2003 <158255876+Xenia2003@users.noreply.github.com>
Co-authored-by: metablaster <44481081+metablaster@users.noreply.github.com>
2025-06-23 23:20:30 +03:00
EmperorPinguin
b4bc02839f
Update CivilianUnitAutomation.kt (#13503) 2025-06-23 23:18:48 +03:00
Rob Loach
d18b78d5f4
Fix number popup with commas in the number (#13495)
* Fix trade gold popup with locale code

* Be verbose and rename the function to toIntOrNullTranslated()
2025-06-23 23:18:25 +03:00
EmperorPinguin
50de8e65c6
AI: update getStatDifferenceFromBuilding (#13492)
* Update

* Update ConstructionAutomation.kt
2025-06-23 23:18:15 +03:00
Rob Loach
9cce7b21bd
Add Gain control over [positiveAmount] tiles [cityFilter] Triggerable (#13489)
* Add 'Expand the border [cityFilter]' Unique

* Update OneTimeExpandBorder

* Add quantifier

* Clean up the code

* Rename and add a test

* Update docs
2025-06-23 23:18:06 +03:00
SomeTroglodyte
fe10b96837
Improve ruleset validator (#13488)
* Mini-refactor: YearsPerTurn can be immutable, support destructuring

* Fixing pass over RulesetValidator

* Make builtin Ruleset clones keep their name and isBaseRuleset

* Prevent repeated cloning in Ruleset.load (borderline optimization)

* Teach AtlasPreview to load complex Rulesets

* Fix filtering Unique check

* Fix ModRequires on base rulesets check

* Add absolutely minimal ModConstants checking
2025-06-23 23:17:57 +03:00