6945 Commits

Author SHA1 Message Date
MohitMali
ca285abab6 Improved search functionality
* Fixed search unit test cases.
* Improved the search functionality to perform the unit test case for search.
2023-07-27 18:07:07 +05:30
MohitMali
731b0a5843 Refactored SearchFragmentTest
* As we can not search in that zim file which is not contains the FT Xapian index and testzim.zim file is not contain it so we have improved our test case.
* Now we are downloading the `off the grid` zim file and performing the search functionality inside it.
2023-07-27 18:06:57 +05:30
MohitMali
32807aa71b Fixed search functionality crash if any FT Xapian index not found in any zim file 2023-07-27 18:06:48 +05:30
MohitMali
824d40680f Fix the instrumentation test cases 2023-07-27 18:06:40 +05:30
MohitMali
f079a1ef88 Using newly published 'libkiwix 1.0.0' from maven 2023-07-27 18:06:33 +05:30
MohitMali
be57a6968e Fixed loading content which contains a query params, mostly this fix is for newly created zim files 2023-07-27 18:06:24 +05:30
MohitMali
75adf8185a Refactored search functionality according to the new wrapper 2023-07-27 18:06:14 +05:30
MohitMaliFtechiz
7a6447c5da Removed the relinker dependency from the project, since now we are loading the .so files on the libkiwix side. Enabled the loadICUData method, since now it is fixed on the libkiwix side. Search and server is now starting successfully, but need some refactoring, for that see next commit. 2023-07-27 18:06:04 +05:30
MohitMali
26ee7fbf1a Refactored code to safely get the metadata of zim files 2023-07-27 18:05:57 +05:30
MohitMali
02f2600270 Start using libkiwix 11.0.0 from maven, loading wrappers .so files for fixing the jni crash which we have missed loading in libkiwix 2023-07-27 18:05:48 +05:30
MohitMali
db195f8d3d Fixed zim file size issue in library section 2023-07-27 18:05:33 +05:30
MohitMali
c34c0c201e Refactoring the search functionality to support the latest wrapper 2023-07-27 18:05:21 +05:30
MohitMali
a3ae9e942b Changes to support libkiwix 11.0.0 wrapper * Get correct zim file title from libkiwix. * Refactor code to get zim file tags from libkiwix * Decode the URL if it is encoded because libkiwix does not return the path for encoded paths. 2023-07-27 18:05:13 +05:30
MohitMali
1476452085 Refactored the code to support the java-libkiwix 11.0.0 2023-07-27 18:05:05 +05:30
Kelson
8469e18e23
Merge pull request #3439 from kiwix/Fixes#3370
Improved the permission asking scenario for custom apps
2023-07-26 07:44:55 +02:00
MohitMaliFtechiz
b1eb76e49b Improved the permission asking scenario for custom apps 2023-07-26 07:44:21 +02:00
Kelson
06c9dbc9ca
Merge pull request #3451 from kiwix/Issue#3441
Fixes of Zim file does not download / pending forever
2023-07-26 07:43:43 +02:00
MohitMali
842a7ee737 Fixed downloading pending forever if we canceled it from notification 2023-07-19 14:08:11 +05:30
Kelson
8a105ae296
Merge pull request #3440 from kiwix/Issue#3409
Introducing deprecated code check in CI
2023-07-19 08:09:43 +02:00
MohitMali
9d49bbbf31 Removed unnecessary classes from the custom rule and suppressed the Compat21 file because we are handling the deprecated code within it. Therefore, we don't want Detekt to check this file for deprecations. 2023-07-19 08:09:31 +02:00
MohitMali
ae5b3a5074 Added RuleSetProvider file to define our custom rules 2023-07-19 08:09:31 +02:00
MohitMali
8e6c74abe8 Introduced custom rule for detekt to exclude the deprecated imports 2023-07-19 08:09:31 +02:00
MohitMali
af23cf56b7 Detecting deprecated code via detekt and fixed detekt detection for the issues in project, and refactored deprecated rules of detekt 2023-07-19 08:09:31 +02:00
Kelson
73fe388514
Merge pull request #3449 from kiwix/Issue#3448
Fixes of View Notes from all books Switch is always enabled
2023-07-19 07:00:45 +02:00
MohitMali
38d6335860 Fixes of View Notes from all books Switch is always enabled 2023-07-19 07:00:35 +02:00
Kelson
c49d8d8ac3
Merge pull request #3447 from kiwix/Issue#3446
Fixes of `UnsafeCallOnNullableType` and `UnnecessaryAbstractClass` issues found by detekt
2023-07-19 06:57:36 +02:00
MohitMali
6e195fc42f Fixed the UnsafeCallOnNullableType detekt issue in the project. 2023-07-18 22:42:54 +02:00
MohitMali
7493b842b7 Fixed UnnecessaryAbstractClass issue of detekt 2023-07-18 22:42:54 +02:00
Kelson
1806495674
Merge pull request #3450 from kiwix/Issue#3395
Fixes of Refactor the Toolbar functionality
2023-07-18 22:41:38 +02:00
MohitMali
eeaceabf0a Fixed test failure 2023-07-18 22:41:12 +02:00
MohitMali
f8594b0183 Moved the common toolbar functionality to the BaseFragment 2023-07-18 22:41:12 +02:00
Kelson
79e43d8735
Merge pull request #3444 from kiwix/Issue#3443
Fixes of Some deprecation warnings are showing in the logs but they are already fixed
2023-07-18 22:40:45 +02:00
MohitMali
7445da9bfc Replaced deprecated onOptionsItemSelected and onCreateOptionsMenu methods with new MenuProvider API. 2023-07-05 18:06:39 +05:30
MohitMali
f2d130c547 Fixes of Some deprecation warnings are showing in the logs but they are already fixed 2023-07-03 18:44:33 +05:30
Kelson
0891512be7
Merge pull request #3433 from kiwix/Issue#3431
Fixes of KiwixWifiP2pBroadcastReceiver using some deprecated methods
2023-06-30 17:00:05 +02:00
MohitMaliFtechiz
ded00766ba Fixes of KiwixWifiP2pBroadcastReceiver using some deprecated methods 2023-06-30 16:59:42 +02:00
Kelson
99f6fdf474
Merge pull request #3420 from kiwix/Issue#3419
Fixes of PreferenceManager.getDefaultSharedPreferences() is deprecated
2023-06-30 16:59:06 +02:00
MohitMaliFtechiz
7d3756af4e Fixes of PreferenceManager.getDefaultSharedPreferences() is deprecated 2023-06-30 16:58:52 +02:00
Kelson
1fd71b51c9
Merge pull request #3436 from kiwix/Issue#3430
Fixed `Toast.getView()` and `Html.fromHtml()` is deprecated
2023-06-28 18:29:26 +02:00
MohitMaliFtechiz
36803af9e2 Fixed Toast.getView() and Html.fromHtml() is deprecated
* We already handled the deprecation of `fromHtml`, we have a string's extension function to handle the this so we are now using that function.
* Since `Toast.getView()` is no longer supported after Android 11 (it always returns null on Android 11 and above devices), we no longer need to show the toast on the ZIM file that is clicked by the user for UI enhancement. Therefore, we have removed this function and are now using the context class extension function to display the toast message.
2023-06-28 18:29:02 +02:00
Kelson
4723d869d2
Merge pull request #3437 from kiwix/Issue#3429
Fixed Auth.kt file using some deprecated method
2023-06-28 18:27:58 +02:00
MohitMaliFtechiz
aa86a88acb Fixed Auth.kt file using some deprecated method 2023-06-28 18:27:50 +02:00
Kelson
8c20953b5d
Merge pull request #3432 from kiwix/Issue#3428
Fixes of Fragment's onActivityCreated is deprecated
2023-06-27 17:24:26 +02:00
MohitMaliFtechiz
8791a824b6 Fixes of Fragment's onActivityCreated is deprecated 2023-06-27 17:23:57 +02:00
Kelson
a32eac811d
Merge pull request #3411 from kiwix/Issue#3351
Fixed some `lintOptions` are deprecated
2023-06-27 17:23:08 +02:00
MohitMaliFtechiz
c18c9d7bba Fixes for some Lint options have been deprecated in newer Gradle versions.
We have introduced a new method, configureCommonExtension, in the AllProjectConfigurer.kt file since Lint is only available in CommonExtension. This allows us to configure Lint in one place for every module. Previously, we couldn't directly use Lint in the android-library project, but with this approach, we can now configure Lint for the android-library project as well.
2023-06-27 17:22:59 +02:00
Kelson
3049494e3d
Merge pull request #3416 from kiwix/Issue#3415
Fixes of `isDrawingCacheEnabled` and `drawingCache` of View class is deprecated
2023-06-27 17:22:19 +02:00
MohitMaliFtechiz
a3de2a25c7 Fixed extra space on the webview top if the webview is not atteched to any view 2023-06-27 17:22:10 +02:00
MohitMaliFtechiz
17cbcf082d Refactor tab preview to use WebView instead of creating a bitmap
This commit introduces changes to the tab preview functionality in order to improve performance and memory usage. The previous approach of creating and storing bitmaps for tab previews has been replaced with a more efficient method utilizing WebView.

Changes Made:
- Modified the onBindViewHolder method in TabsAdapter to utilize WebView for tab previews.
- Removed the ImageUtils.kt class as it is no longer needed for bitmap storage.

Impact:
- Improved performance and reduced memory usage by directly displaying the WebView for tab previews.
- Eliminated the need for bitmap creation and storage, resulting in a more efficient implementation.
2023-06-27 17:22:10 +02:00
MohitMaliFtechiz
03ee22eb8a Removing the bitmap dependency to show the preview image 2023-06-27 17:22:10 +02:00